You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/08/05 11:51:59 UTC

[GitHub] tajo pull request: TAJO-994: 'count(distinct x)' function counts f...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/106

    TAJO-994: 'count(distinct x)' function counts first null value.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-994

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit 2466c4a22133cc2cd495e5fc8c7126caf7586cc7
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-08-05T09:50:58Z

    TAJO-994: 'count(distinct x)' function counts first null value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-994: 'count(distinct x)' function counts f...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/106#issuecomment-51736017
  
    +1 
    
    Thanks  your contribution.
    I agree with your opinion and the patch looks good to me.
    'mvn clean install' finished successfully.
    
    Ship it. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-994: 'count(distinct x)' function counts f...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---