You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/13 14:00:53 UTC
[GitHub] [beam-starter-go] jrmccluskey opened a new pull request, #3: Use generic registration over legacy route in main.go
jrmccluskey opened a new pull request, #3:
URL: https://github.com/apache/beam-starter-go/pull/3
Updates main.go to use the new generic approach to function and emitter registration over the legacy approach. This also results in the minimum Go version being incremented to 2.40.0.
Fixes #2
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] I agree that my contributions are licensed with both [Apache ASL2](../../LICENSE-APACHE) and [MIT](../../LICENSE-MIT).
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [`CONTRIBUTING.md`](../../CONTRIBUTING.md) guide for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] davidcavazos commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
davidcavazos commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920443466
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
I opened #4, hopefully that'll take care of it. Thanks for the reference file, I was reading through the docs but didn't know it was that easy to enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] davidcavazos commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
davidcavazos commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920429399
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
Yes, we can make that part of the Beam release guide. Eventually it would be nice to use [Dependabot](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/about-dependabot-version-updates) to automatically update all versions and automerge them as long as tests pass. These "Hello Worlds" are so simple that it should be safe to update everything to the latest version automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] damccorm commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920124215
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
This is out of the scope of this PR, but we may want a strategy for bumping this dependency as part of our release process. @davidcavazos how have we been handling this (if at all) in the other starter repos? Should this be added to the [beam release guide](https://beam.apache.org/contribute/release-guide/)?
@jrmccluskey this comment isn't meant to hold up merging this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] damccorm commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920432041
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
Agreed - should be pretty straightforward, probably all it takes is adding a file like this - https://github.com/apache/beam/commit/fbc495c66e7b36a6033d3ff0c44a5e0050060dec - but simpler since we only care about one language per repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] jrmccluskey merged pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey merged PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] lostluck commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920205871
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
I'm biased to agree. It's trivial for Go, and about the same for the others. We'd likely want a script to generate the PRs however.
Everything else that bumps the version uses a script for it. The main complication is the additional repos to set up locally...
Another awkward bit is that it would need to not be merged until after the release is finalized...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam-starter-go] damccorm commented on a diff in pull request #3: Use generic registration over legacy route in main.go
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #3:
URL: https://github.com/apache/beam-starter-go/pull/3#discussion_r920449983
##########
go.mod:
##########
@@ -2,7 +2,7 @@ module example.com/my_app
go 1.18
-require github.com/apache/beam/sdks/v2 v2.39.0
+require github.com/apache/beam/sdks/v2 v2.40.0
Review Comment:
There's a chance we'll need to engage infra to enable dependabot for the repo, but I think this should do it. Either way we need it for things to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org