You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by al...@apache.org on 2014/07/09 22:24:08 UTC
[3/4] git commit: Make code more clear, user message more informative.
Make code more clear, user message more informative.
Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/c759a089
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/c759a089
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/c759a089
Branch: refs/heads/master
Commit: c759a089a7c3fa70ddb0c4ada34a2e4d2865cc9d
Parents: ddb48c5
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Tue Jul 8 21:54:53 2014 +0300
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Tue Jul 8 21:54:53 2014 +0300
----------------------------------------------------------------------
.../java/brooklyn/test/PlatformTestSelectorListener.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/c759a089/utils/test-support/src/main/java/brooklyn/test/PlatformTestSelectorListener.java
----------------------------------------------------------------------
diff --git a/utils/test-support/src/main/java/brooklyn/test/PlatformTestSelectorListener.java b/utils/test-support/src/main/java/brooklyn/test/PlatformTestSelectorListener.java
index 6d8bc2d..0b31781 100644
--- a/utils/test-support/src/main/java/brooklyn/test/PlatformTestSelectorListener.java
+++ b/utils/test-support/src/main/java/brooklyn/test/PlatformTestSelectorListener.java
@@ -19,16 +19,17 @@ public class PlatformTestSelectorListener implements IInvokedMethodListener {
boolean isWinTest = false;
String[] groups = method.getTestMethod().getGroups();
- for(String group : groups) {
+ for (String group : groups) {
isUnixTest = isUnixTest || group.equalsIgnoreCase(GROUP_UNIX);
isWinTest = isWinTest || group.equalsIgnoreCase(GROUP_WINDOWS);
}
boolean isWinPlatform = isWindows();
- if(isUnixTest || isWinTest) {
- if(isWinPlatform && isUnixTest && !isWinTest ||
- !isWinPlatform && isWinTest && !isUnixTest) {
- throw new SkipException("Skipping platform specific test.");
+ if (isUnixTest || isWinTest) {
+ if (isWinPlatform && isUnixTest && !isWinTest) {
+ throw new SkipException("Skipping unix-specific test.");
+ } else if (!isWinPlatform && isWinTest && !isUnixTest) {
+ throw new SkipException("Skipping windows-specific test.");
}
}
}