[GitHub] [dubbo-go] MasterKenway commented on a change in pull request #1469: Feat: config enhance (service discovery)

[GitBox <gi...@apache.org>]

MasterKenway commented on a change in pull request #1469:
URL: https://github.com/apache/dubbo-go/pull/1469#discussion_r713835205



##########
File path: registry/nacos/service_discovery.go
##########
@@ -218,14 +218,15 @@ func (n *nacosServiceDiscovery) AddListener(listener registry.ServiceInstancesCh
 	for _, t := range listener.GetServiceNames().Values() {
 		serviceName := t.(string)
 		err := n.namingClient.Client().Subscribe(&vo.SubscribeParam{
-			ServiceName: serviceName,
 			GroupName:   n.group,
+			ServiceName: serviceName,
 			SubscribeCallback: func(services []model.SubscribeService, err error) {
 				if err != nil {
 					logger.Errorf("Could not handle the subscribe notification because the err is not nil."+
 						" service name: %s, err: %v", serviceName, err)
 				}
 				instances := make([]registry.ServiceInstance, 0, len(services))
+				logger.Infof("%v", services)

Review comment:
       test case which forget to be removed, sorry for my mistake




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org