[GitHub] [solr] dsmiley commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531488428

   Sure; will remove from the configs in Solr -- easy enough.
   
   Why modify solr.in.sh at all?  I'd rather not; to be honest, I'd rather that file not exist at all (by default).
   
   If/once Solr has a solr.env=prod|dev|test then we'd enable this setting in dev mode, and then feel no need later to give it such first class treatment to deserve it's very own env (which I assume is what motivated you to suggest an entry in solr.in.sh?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org