You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/05/30 19:14:29 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #871:
HDDS-1579. Create OMDoubleBuffer metrics.
xiaoyuyao commented on a change in pull request #871: HDDS-1579. Create OMDoubleBuffer metrics.
URL: https://github.com/apache/hadoop/pull/871#discussion_r289132386
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##########
@@ -134,6 +141,23 @@ private void flushTransactions() {
}
}
+ /**
+ * Set OzoneManagerDoubleBuffer metrics values.
+ * @param flushedTransactionsSize
+ */
+ private void setOzoneManagerDoubleBufferMetrics(
+ long flushedTransactionsSize) {
+ ozoneManagerDoubleBufferMetrics.incTotalNumOfFlushIterations();
+ ozoneManagerDoubleBufferMetrics.setTotalNumOfFlushedTransactions(
Review comment:
NIT: setTotalNumOfFlushedTransactions is confusing. Should we rename it to setTotalSizeOfFlushedTransactions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org