You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/01/20 17:29:53 UTC
Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/
-----------------------------------------------------------
Review request for Ambari and Sumit Mohanty.
Bugs: AMBARI-19654
https://issues.apache.org/jira/browse/AMBARI-19654
Repository: ambari
Description
-------
Added log messages to ambari_main_server and increased the timeout for server start
Diffs
-----
ambari-server/src/main/python/ambari_server_main.py a3fb08d
Diff: https://reviews.apache.org/r/55775/diff/
Testing
-------
Output:
[root@mradha-amupg-1 /]# ambari-server start
Using python /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
Ambari database consistency check started...
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /var/log/ambari-server/ambari-server.out
Server log at: /var/log/ambari-server/ambari-server.log
Waiting for server start.........
Server PID determined Ambari Server has started successfully
Ambari Server 'start' completed successfully.
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> > What's the root cause of failures?
>
> Madhuvanthi Radhakrishnan wrote:
> Hi,
> Due to slow hardware, the server start timed out and resulted in an exception for ther ambari-server.out file.
> After this, when user issued ambari-server start again, it completed.
I think timeouts that high may hide root causes. Let's keep it at 4, thanks
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162469
-----------------------------------------------------------
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> > What's the root cause of failures?
>
> Madhuvanthi Radhakrishnan wrote:
> Hi,
> Due to slow hardware, the server start timed out and resulted in an exception for ther ambari-server.out file.
> After this, when user issued ambari-server start again, it completed.
>
> Alejandro Fernandez wrote:
> I think timeouts that high may hide root causes. Let's keep it at 4, thanks
>
> Alejandro Fernandez wrote:
> meant to say retries, not timeouts
On second thought, yes, lets revert to 4. We can introduce a configurable parameter that can be set on slower VMs or containers. We can do that as a separate patch.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162469
-----------------------------------------------------------
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> > What's the root cause of failures?
>
> Madhuvanthi Radhakrishnan wrote:
> Hi,
> Due to slow hardware, the server start timed out and resulted in an exception for ther ambari-server.out file.
> After this, when user issued ambari-server start again, it completed.
>
> Alejandro Fernandez wrote:
> I think timeouts that high may hide root causes. Let's keep it at 4, thanks
meant to say retries, not timeouts
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162469
-----------------------------------------------------------
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On Jan. 20, 2017, 7:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server_main.py, line 106
> > <https://reviews.apache.org/r/55775/diff/1/?file=1610796#file1610796line106>
> >
> > Why does this need to be so high?
> > What's the root cause of failures?
Hi,
Due to slow hardware, the server start timed out and resulted in an exception for ther ambari-server.out file.
After this, when user issued ambari-server start again, it completed.
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162469
-----------------------------------------------------------
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162469
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server_main.py (line 106)
<https://reviews.apache.org/r/55775/#comment233798>
Why does this need to be so high?
What's the root cause of failures?
- Alejandro Fernandez
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162515
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 20, 2017, 9:16 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 9:16 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 9:16 p.m.)
Review request for Ambari and Sumit Mohanty.
Changes
-------
Reverted back server_tries from 10 to 4. Fixed the identation.
Bugs: AMBARI-19654
https://issues.apache.org/jira/browse/AMBARI-19654
Repository: ambari
Description
-------
Added log messages to ambari_main_server and increased the timeout for server start
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server_main.py a3fb08d
Diff: https://reviews.apache.org/r/55775/diff/
Testing
-------
Output:
[root@mradha-amupg-1 /]# ambari-server start
Using python /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
Ambari database consistency check started...
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /var/log/ambari-server/ambari-server.out
Server log at: /var/log/ambari-server/ambari-server.log
Waiting for server start.........
Server PID determined Ambari Server has started successfully
Ambari Server 'start' completed successfully.
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162450
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 55775: Added log messages to ambari_main_server and
increased the timeout for server start
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55775/#review162503
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server_main.py (line 228)
<https://reviews.apache.org/r/55775/#comment233820>
Actually, this if may have been indented too much. It should not be part of the for loop
- Sumit Mohanty
On Jan. 20, 2017, 5:29 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55775/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 5:29 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-19654
> https://issues.apache.org/jira/browse/AMBARI-19654
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added log messages to ambari_main_server and increased the timeout for server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server_main.py a3fb08d
>
> Diff: https://reviews.apache.org/r/55775/diff/
>
>
> Testing
> -------
>
> Output:
> [root@mradha-amupg-1 /]# ambari-server start
> Using python /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.........
> Server PID determined Ambari Server has started successfully
> Ambari Server 'start' completed successfully.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>