[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2756: ARTEMIS-2408 Effectively reverting FileDescriptors check as testsuite…

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2756: ARTEMIS-2408 Effectively reverting FileDescriptors check as testsuite…
URL: https://github.com/apache/activemq-artemis/pull/2756#discussion_r304182776
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java
 ##########
 @@ -408,27 +407,15 @@ public void stop(final boolean criticalError) throws Exception {
          conn.disconnect(criticalError);
       }
 
-      Map<Acceptor, Future<?>> acceptorFutures = new HashMap<>();
       for (Acceptor acceptor : acceptors.values()) {
          try {
-            acceptorFutures.put(acceptor, acceptor.asyncStop());
+            acceptor.stop();
          } catch (Throwable t) {
             ActiveMQServerLogger.LOGGER.errorStoppingAcceptor(acceptor.getName());
          }
       }
 
-      for (Map.Entry<Acceptor, Future<?>> acceptorFuture : acceptorFutures.entrySet()) {
-         if (acceptorFuture.getValue() != null) {
-            try {
-               acceptorFuture.getValue().get();
 
 Review comment:
   @brusdev there's probably some issue with some Failover tests on getting the return here without a timeout.
   
   Probably a timeout of 1 sec here would suffice, as we just want to make sure we actually close the acceptors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services