You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 12:50:16 UTC
[GitHub] [flink] TsReaper commented on a change in pull request #13636: [FLINK-19641][hive] Optimize parallelism calculating of HiveTableSource by checking file number
TsReaper commented on a change in pull request #13636:
URL: https://github.com/apache/flink/pull/13636#discussion_r510860668
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -210,19 +212,35 @@ private boolean isStreamingSource() {
" cannot be less than 1");
}
- int splitNum;
try {
- long nano1 = System.nanoTime();
- splitNum = inputFormat.createInputSplits(0).length;
- long nano2 = System.nanoTime();
+ // `createInputSplits` is costly,
Review comment:
I don't think this is needed, at least in this PR. This PR is only an optimization and code cleanups should be done in separate PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org