You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2017/02/21 23:13:26 UTC
Review Request 56902: make explain formatted to include opId and etc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56902/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-15955
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 74cec3e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java c6287e4
ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java b8c2d42
ql/src/test/queries/clientpositive/explain_formatted_oid.q PRE-CREATION
ql/src/test/results/clientpositive/explain_formatted_oid.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/56902/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 56902: make explain formatted to include opId and
etc
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56902/#review166282
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java (line 86)
<https://reviews.apache.org/r/56902/#comment238202>
Please mark this as transient.
- Ashutosh Chauhan
On Feb. 21, 2017, 11:13 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56902/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 11:13 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15955
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 74cec3e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java c6287e4
> ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java b8c2d42
> ql/src/test/queries/clientpositive/explain_formatted_oid.q PRE-CREATION
> ql/src/test/results/clientpositive/explain_formatted_oid.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 56902: make explain formatted to include opId and
etc
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56902/#review166276
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java (line 799)
<https://reviews.apache.org/r/56902/#comment238190>
Declare string constants as class variable.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java (lines 44 - 48)
<https://reviews.apache.org/r/56902/#comment238192>
Copy-paste?
ql/src/test/queries/clientpositive/explain_formatted_oid.q (line 1)
<https://reviews.apache.org/r/56902/#comment238196>
This should not be necessary. May as well.
- Ashutosh Chauhan
On Feb. 21, 2017, 11:13 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56902/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 11:13 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15955
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 74cec3e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java c6287e4
> ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java b8c2d42
> ql/src/test/queries/clientpositive/explain_formatted_oid.q PRE-CREATION
> ql/src/test/results/clientpositive/explain_formatted_oid.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 56902: make explain formatted to include opId and
etc
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56902/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 4:24 a.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HIVE-15955
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 74cec3e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/AnnotateReduceSinkOutputOperator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java c6287e4
ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java b8c2d42
ql/src/test/queries/clientpositive/explain_formatted_oid.q PRE-CREATION
ql/src/test/results/clientpositive/explain_formatted_oid.q.out PRE-CREATION
ql/src/test/results/clientpositive/input4.q.out 83912f6
ql/src/test/results/clientpositive/join0.q.out c02319e
ql/src/test/results/clientpositive/parallel_join0.q.out c02319e
ql/src/test/results/clientpositive/plan_json.q.out 75d5b73
ql/src/test/results/clientpositive/vector_outer_join3.q.out 49c658b
ql/src/test/results/clientpositive/vector_outer_join4.q.out fce35a1
ql/src/test/results/clientpositive/vector_outer_join6.q.out a910ed2
Diff: https://reviews.apache.org/r/56902/diff/
Testing
-------
Thanks,
pengcheng xiong