You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/07/28 19:08:19 UTC
[GitHub] nifi pull request #740: Message on history page when clustered
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/740
Message on history page when clustered
NIFI-2302:
- Showing a message on the history page when in a cluster to indicate that only the actions from the current node are displayed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-2302
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #740
----
commit bdda93c626c505634c2c52097425c2ed7b76f001
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-07-28T19:07:16Z
NIFI-2302:
- Showing a message on the history page when in a cluster to indicate that only the actions from the current node are displayed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
I was a bit confused by the message at first, I took it to mean "this history only shows changes that were made on this node" and was confused when I saw changes from every node on the history of each node. I'm not sure the most succinct/correct way to phrase it but maybe something more like "this history shows all changes made to the cluster while this node was connected"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/740
Do you have another suggestion for the message? What if we create another JIRA for further explanation in the user guide? Tough to explain the scenario in a short sentence or two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
After sleeping on it, I agree with you.
+1
Visually verified code, and did a contrib check build. In 3 node secure cluster and standalone verified that the message appeared when expected and history displayed what was expected. Thanks @mcgilman, I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
Yup, that was my confusion and I think the target user of this message (people not really familiar with the in's/out's of clustering) will get hung up on that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/740
The message is only shown when the node is part of a cluster. I think we shouldn't overcomplicate things. Inform the user that they are viewing the history of the current node and suggest they can browse to another node to view it's history. I believe this is a clear, simple, and accurate description of what is being display and what other options the user has.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
Hmmm, not sure if it's too long but maybe something like (first sentence is probably optional):
Viewing the history of the current node only. This history includes changes that were made as a standalone instance and any changes replicated to this instance(?) as a node of a cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/740
Each node processed each action regardless if your browser was pointed to it. That's how the flows are kept in sync. The potential confusion here is with actions that happened to a node when it was not part of the cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
Sorry more specifically, I have a 3 node cluster and made one change on each (while all were connected), I didn't expect to see all three of the changes in the history of each node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #740: Message on history page when clustered
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/740
Your first impression of that message is accurate. We are only showing actions from the node the browser is pointing to. Meaning, if that node has other history before it was clustered it would be available. Each node is only showing the history it knows about. If every node was only part of its current cluster then all nodes would report the same history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #740: Message on history page when clustered
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---