You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/28 18:55:19 UTC
[GitHub] [superset] codecov[bot] commented on pull request #22248: chore: Add a migration that removes filter_bar_orientation from dashboard's json_metadata
codecov[bot] commented on PR #22248:
URL: https://github.com/apache/superset/pull/22248#issuecomment-1329590984
# [Codecov](https://codecov.io/gh/apache/superset/pull/22248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22248](https://codecov.io/gh/apache/superset/pull/22248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e99fce2) into [master](https://codecov.io/gh/apache/superset/commit/435926b89e08395f3017a32ea00f3de252fd4fb7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (435926b) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22248 +/- ##
==========================================
+ Coverage 55.46% 55.63% +0.16%
==========================================
Files 1841 1841
Lines 70220 70220
Branches 7670 7670
==========================================
+ Hits 38947 39066 +119
+ Misses 29291 29172 -119
Partials 1982 1982
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.56% <ø> (?)` | |
| presto | `52.45% <ø> (ø)` | |
| python | `57.80% <ø> (+0.35%)` | :arrow_up: |
| unit | `50.87% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `64.20% <0.00%> (+0.10%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `75.14% <0.00%> (+0.39%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `75.78% <0.00%> (+1.25%)` | :arrow_up: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `79.71% <0.00%> (+2.17%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `80.58% <0.00%> (+2.91%)` | :arrow_up: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `64.82% <0.00%> (+30.43%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/22248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `85.18% <0.00%> (+85.18%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org