You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/08 12:52:29 UTC
[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #1081: nimble/ll: Fix starting ctrl proc timer
andrzej-kaczmarek opened a new pull request #1081:
URL: https://github.com/apache/mynewt-nimble/pull/1081
We cannot just initialize callout prior to restarting since this will
wipe it out and thus break callouts queue if it was already added there.
Instead, initialize once on module init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1081: nimble/ll: Fix starting ctrl proc timer
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #1081:
URL: https://github.com/apache/mynewt-nimble/pull/1081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1081: nimble/ll: Fix starting ctrl proc timer
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #1081:
URL: https://github.com/apache/mynewt-nimble/pull/1081#discussion_r744831849
##########
File path: nimble/controller/src/ble_ll_ctrl.c
##########
@@ -2886,3 +2881,10 @@ ble_ll_ctrl_tx_done(struct os_mbuf *txpdu, struct ble_ll_conn_sm *connsm)
os_mbuf_free_chain(txpdu);
return rc;
}
+
+void
+ble_ll_ctrl_init_conn_sm(struct ble_ll_conn_sm *connsm)
+{
+ ble_npl_callout_init(&connsm->ctrl_proc_rsp_timer, &g_ble_ll_data.ll_evq,
+ ble_ll_ctrl_proc_rsp_timer_cb, connsm);
+}
Review comment:
nitpick, no new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org