You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Momchil Velikov <ve...@fadata.bg> on 2002/11/07 08:40:17 UTC
[PATCH] fix for a missing include
Hi there,
I have a system with a libxmltok installed (Debian package
libxmlrok1-dev), so configure detects it ans set SVN_HAVE_OLD_EXPAT.
Unfortunately, this macro is not picked up by svn_xml.h, which tries
to include the nonexistent expat.h.
~velco
Re: [PATCH] fix for a missing include
Posted by Justin Erenkrantz <je...@apache.org>.
--On Friday, November 8, 2002 11:10 AM +0000 Philip Martin
<ph...@codematters.co.uk> wrote:
> I think we need a patch that adds SVN_HAVE_OLD_EXPAT to the CPPFLAGS
> used to build Subversion. The patch should also modify the
> svn-config script so that svn-config --cppflags includes
> SVN_HAVE_OLD_EXPAT to support compiling from the installed
> Subversion with the correct flags.
Eek. Why not just have a public svn_config.h file that is installed?
(Err, svn_config.h is taken, but you get my idea.) -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix for a missing include
Posted by Philip Martin <ph...@codematters.co.uk>.
Momchil Velikov <ve...@fadata.bg> writes:
> Hi there,
>
> I have a system with a libxmltok installed (Debian package
> libxmlrok1-dev), so configure detects it ans set SVN_HAVE_OLD_EXPAT.
> Unfortunately, this macro is not picked up by svn_xml.h, which tries
> to include the nonexistent expat.h.
>
> ~velco
> Index: svn_xml.h
> ===================================================================
> --- svn_xml.h (revision 3672)
> +++ svn_xml.h (working copy)
> @@ -24,6 +24,8 @@
> #include <apr_pools.h>
> #include <apr_hash.h>
>
> +#include "svn_private_config.h"
> +
> #ifdef SVN_HAVE_OLD_EXPAT
> #include "xmlparse.h"
> #else
I think we need a patch that adds SVN_HAVE_OLD_EXPAT to the CPPFLAGS
used to build Subversion. The patch should also modify the svn-config
script so that svn-config --cppflags includes SVN_HAVE_OLD_EXPAT to
support compiling from the installed Subversion with the correct
flags.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix for a missing include
Posted by Philip Martin <ph...@codematters.co.uk>.
Philip Martin <ph...@codematters.co.uk> writes:
> Momchil Velikov <ve...@fadata.bg> writes:
>
> > Index: svn_xml.h
> > ===================================================================
> > --- svn_xml.h (revision 3672)
> > +++ svn_xml.h (working copy)
> > @@ -24,6 +24,8 @@
> > #include <apr_pools.h>
> > #include <apr_hash.h>
> >
> > +#include "svn_private_config.h"
> > +
> > #ifdef SVN_HAVE_OLD_EXPAT
> > #include "xmlparse.h"
> > #else
>
> Applied in rev 3690, thanks.
And reverted in 3691 :-/
The problem is that svn_xml.h is installed, but svn_private_config.h
isn't. I don't know how we should handle this.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix for a missing include
Posted by Philip Martin <ph...@codematters.co.uk>.
Momchil Velikov <ve...@fadata.bg> writes:
> Index: svn_xml.h
> ===================================================================
> --- svn_xml.h (revision 3672)
> +++ svn_xml.h (working copy)
> @@ -24,6 +24,8 @@
> #include <apr_pools.h>
> #include <apr_hash.h>
>
> +#include "svn_private_config.h"
> +
> #ifdef SVN_HAVE_OLD_EXPAT
> #include "xmlparse.h"
> #else
Applied in rev 3690, thanks.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org