[GitHub] [helix] narendly commented on a change in pull request #894: Make ZkBucketDataAccessor realm-aware

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #894: Make ZkBucketDataAccessor realm-aware
URL: https://github.com/apache/helix/pull/894#discussion_r392537150
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java
 ##########
 @@ -73,8 +77,22 @@
    * @param versionTTL in ms
    */
   public ZkBucketDataAccessor(String zkAddr, int bucketSize, long versionTTL) {
-    _zkClient = DedicatedZkClientFactory.getInstance()
-        .buildZkClient(new HelixZkClient.ZkConnectionConfig(zkAddr));
+    if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED)) {
 
 Review comment:
   This config should follow wherever all Helix system config properties go. I am not sure about what you mean by HelixProperty solution, but if there's an agreed-upon place we should group all configs in, then this should go with them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org