[jira] [Commented] (THRIFT-3916) Errors thrown from JavaScript client is strings and not errors

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396995#comment-16396995 ] 

ASF GitHub Bot commented on THRIFT-3916:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1075
  
    @bananer is this worth pulling forward if it passes a build?  Is it a breaking change?


> Errors thrown from JavaScript client is strings and not errors
> --------------------------------------------------------------
>
>                 Key: THRIFT-3916
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3916
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Compiler
>            Reporter: Simen Bekkhus
>            Priority: Minor
>              Labels: javascript
>
> In JavaScript, you can {{throw}} any object, including strings, but to get stack traces one should throw {{Errors}}.
> The generated JS code throws the error string directly, instead of wrapping it in {{new Error}}.
> Node core _only_ rejects with/throws Errors, never strings, and Thrift should follow the same standard.
> https://nodejs.org/api/errors.html#errors_class_error
> {quote}
> All errors generated by Node.js, including all System and JavaScript errors, will either be instances of, or inherit from, the Error class.
> {quote}
> PR for the change [here|https://github.com/apache/thrift/pull/1075].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)