[GitHub] [beam] pabloem commented on a change in pull request #15839: [BEAM-13041][Playground] Prepare files with java code

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15839:
URL: https://github.com/apache/beam/pull/15839#discussion_r740699500



##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -0,0 +1,142 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package preparators
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"log"
+	"os"
+	"regexp"
+	"strings"
+)
+
+const (
+	classWithPublicModifierPattern    = "public class "
+	classWithoutPublicModifierPattern = "class "
+	packagePattern                    = `package ([\w]+\.)+[\w]+;`
+	emptyStringPattern                = ""
+	newLinePattern                    = "\n"
+	pathSeparatorPattern              = os.PathSeparator
+	tmpFileSuffix                     = "tmp"
+)
+
+// GetJavaPreparators returns preparation methods that should be applied to Java code
+func GetJavaPreparators(filePath string) *[]Preparator {
+	publicClassModification := Preparator{

Review comment:
       why are we adding this modification? is there a problem with public classes?

##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -0,0 +1,142 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package preparators
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"log"

Review comment:
       let's use our logging library

##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -0,0 +1,142 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package preparators
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"log"
+	"os"
+	"regexp"
+	"strings"
+)
+
+const (
+	classWithPublicModifierPattern    = "public class "
+	classWithoutPublicModifierPattern = "class "
+	packagePattern                    = `package ([\w]+\.)+[\w]+;`

Review comment:
       let's match the start of a new line as well?
   (e.g. what about files with `System.out.println("a package was.put.here;");)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org