You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Dan Diephouse (JIRA)" <be...@incubator.apache.org> on 2004/11/24 23:25:18 UTC
[jira] Created: (BEEHIVE-97) Event notifiers aren't registered for Control extensions
Event notifiers aren't registered for Control extensions
--------------------------------------------------------
Key: BEEHIVE-97
URL: http://nagoya.apache.org/jira/browse/BEEHIVE-97
Project: Beehive
Type: Bug
Reporter: Dan Diephouse
I am extending a control, and the Event notifier isn't registered when I use the extended control (only when I use the non-extended control).
To understand, look at these constructors:
public XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props)
{
super(context, id, props, org.controlhaus.xfire.client.XFireClientControl.class);
//
// Register event notifier instances for any EventSets
//
setEventNotifier(EndInvokeCallback.class, new EndInvokeCallbackNotifier());
}
/**
* This is the protected version that is used by any ControlBean subclass
*/
protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
Class controlClass)
{
super(context, id, props, controlClass);
}
The event notifier is only registered in the first case, but should be registered in both. Extended controls call teh second constructor, so it doesn't receive any events. So, "super" should just be changed to "this":
/**
* This is the protected version that is used by any ControlBean subclass
*/
protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
Class controlClass)
{
this(context, id, props, controlClass);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-97) Event notifiers aren't registered for Control extensions
Posted by "Kyle Marvin (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-97?page=history ]
Kyle Marvin resolved BEEHIVE-97:
--------------------------------
Resolution: Fixed
Fix Version: TBD
The fix is in, as of r109374
> Event notifiers aren't registered for Control extensions
> --------------------------------------------------------
>
> Key: BEEHIVE-97
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-97
> Project: Beehive
> Type: Bug
> Reporter: Dan Diephouse
> Assignee: Kyle Marvin
> Fix For: TBD
>
> I am extending a control, and the Event notifier isn't registered when I use the extended control (only when I use the non-extended control).
> To understand, look at these constructors:
> public XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props)
> {
> super(context, id, props, org.controlhaus.xfire.client.XFireClientControl.class);
>
> //
> // Register event notifier instances for any EventSets
> //
> setEventNotifier(EndInvokeCallback.class, new EndInvokeCallbackNotifier());
> }
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> super(context, id, props, controlClass);
> }
> The event notifier is only registered in the first case, but should be registered in both. Extended controls call teh second constructor, so it doesn't receive any events. So, "super" should just be changed to "this":
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> this(context, id, props, controlClass);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-97) Event notifiers aren't registered for Control extensions
Posted by "Kyle Marvin (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-97?page=history ]
Kyle Marvin reassigned BEEHIVE-97:
----------------------------------
Assign To: Kyle Marvin
I'll take a look at this
> Event notifiers aren't registered for Control extensions
> --------------------------------------------------------
>
> Key: BEEHIVE-97
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-97
> Project: Beehive
> Type: Bug
> Reporter: Dan Diephouse
> Assignee: Kyle Marvin
>
> I am extending a control, and the Event notifier isn't registered when I use the extended control (only when I use the non-extended control).
> To understand, look at these constructors:
> public XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props)
> {
> super(context, id, props, org.controlhaus.xfire.client.XFireClientControl.class);
>
> //
> // Register event notifier instances for any EventSets
> //
> setEventNotifier(EndInvokeCallback.class, new EndInvokeCallbackNotifier());
> }
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> super(context, id, props, controlClass);
> }
> The event notifier is only registered in the first case, but should be registered in both. Extended controls call teh second constructor, so it doesn't receive any events. So, "super" should just be changed to "this":
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> this(context, id, props, controlClass);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-97) Event notifiers aren't registered for Control extensions
Posted by "Kyle Marvin (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-97?page=comments#action_55992 ]
Kyle Marvin commented on BEEHIVE-97:
------------------------------------
Fix coming on my next checkin. The public constructor should invoke the (locally declared) protected constructor, and notifier initialization should take place there (so it happens for both use cases).
Nice catch, Dan!
> Event notifiers aren't registered for Control extensions
> --------------------------------------------------------
>
> Key: BEEHIVE-97
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-97
> Project: Beehive
> Type: Bug
> Reporter: Dan Diephouse
> Assignee: Kyle Marvin
>
> I am extending a control, and the Event notifier isn't registered when I use the extended control (only when I use the non-extended control).
> To understand, look at these constructors:
> public XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props)
> {
> super(context, id, props, org.controlhaus.xfire.client.XFireClientControl.class);
>
> //
> // Register event notifier instances for any EventSets
> //
> setEventNotifier(EndInvokeCallback.class, new EndInvokeCallbackNotifier());
> }
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> super(context, id, props, controlClass);
> }
> The event notifier is only registered in the first case, but should be registered in both. Extended controls call teh second constructor, so it doesn't receive any events. So, "super" should just be changed to "this":
> /**
> * This is the protected version that is used by any ControlBean subclass
> */
> protected XFireClientControlBean(ControlBeanContext context, String id, PropertyMap props,
> Class controlClass)
> {
> this(context, id, props, controlClass);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira