You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/24 17:25:15 UTC
[Impala-ASF-CR] IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24938
Change subject: IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
......................................................................
IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Reapply Impala's customizations on top of the new upstream
CMakeLists.txt files:
- Add the kudu-{util,security,rpc}-proto-deps aggregate targets.
- Add KUDU_HEADERS_USE_SHORT_STATUS_MACROS definitions.
- Skip building files Impala does not use (char_util.cc, file_cache.cc,
minidump.cc, yamlreader.cc, version_info.cc) and the AVX2 detection
block (Impala centralizes AVX2 detection in be/CMakeLists.txt).
- Force-enable kudu_test_util/mini_kdc since Impala relies on them.
- Give protoc-gen-insertions/protoc-gen-krpc their Impala-specific
extra link dependencies.
- Skip the yaml lib and instance_detector-test, which Impala does not
build.
Most of the Impala-local patches previously carried on top of Kudu
1.17.1 (RSASSA-PSS cert support, ARM64 NEON, Prometheus metrics
refactor, env_posix ssl_make_unique) are now upstream in d06637b27 and
need no reapplication. The remainder, which are Impala-only
integration points not part of Kudu proper, are reapplied here:
- security/init.cc, util/flags.cc, util/logging.cc: declare (rather
than define) flags that Impala itself defines in
common/global-flags.cc, and skip BlockSigUSR1() since Impala does
not link Kudu's minidump library.
- security/gssapi.cc: dedicated SPNEGO keytab flag (IMPALA-12318).
- security/test/mini_kdc.cc: hardcode /tmp for the KDC data root,
since GetTestDataDirectory() depends on gmock, which Impala's
toolchain lacks.
- util/curl_util.{cc,h}: verify JWKS URL server TLS certs by default
and support a configurable CA bundle (IMPALA-11922).
- util/debug/unwind_safeness.cc: tolerate missing dlopen/dlclose
symbols under IMPALA_SHARED_LIBRARY builds (IMPALA-11640/11641).
- util/web_callback_registry.h: source_socket/source_user fields used
by the webserver (IMPALA-9182, IMPALA-10779).
- rpc/transfer.cc: hide --rpc_max_message_size from --help.
Assisted-by: Claude Sonnet 5 (GitHub Copilot)
Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/kudu/rpc/transfer.cc
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/security/gssapi.cc
M be/src/kudu/security/init.cc
M be/src/kudu/security/test/mini_kdc.cc
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
M be/src/kudu/util/debug/unwind_safeness.cc
M be/src/kudu/util/flags.cc
M be/src/kudu/util/logging.cc
M be/src/kudu/util/web_callback_registry.h
13 files changed, 157 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/24938/1
--
To view, visit http://gerrit.cloudera.org:8080/24938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
Gerrit-Change-Number: 24938
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24938 )
Change subject: IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/24169/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
Gerrit-Change-Number: 24938
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Sep 2026 17:50:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24938 )
Change subject: IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/24487/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
Gerrit-Change-Number: 24938
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2026 19:02:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24938
to look at the new patch set (#2).
Change subject: IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
......................................................................
IMPALA-15359: (Part 2) Restore Impala-specific Kudu patches
Reapply Impala's customizations on top of the new upstream
CMakeLists.txt files:
- Add the kudu-{util,security,rpc}-proto-deps aggregate targets.
- Add KUDU_HEADERS_USE_SHORT_STATUS_MACROS definitions.
- Skip building files Impala does not use (char_util.cc, file_cache.cc,
minidump.cc, yamlreader.cc, version_info.cc) and the AVX2 detection
block (Impala centralizes AVX2 detection in be/CMakeLists.txt).
- Force-enable kudu_test_util/mini_kdc since Impala relies on them.
- Give protoc-gen-insertions/protoc-gen-krpc their Impala-specific
extra link dependencies.
- Skip the yaml lib and instance_detector-test, which Impala does not
build.
Most of the Impala-local patches previously carried on top of Kudu
1.17.1 (RSASSA-PSS cert support, ARM64 NEON, Prometheus metrics
refactor, env_posix ssl_make_unique) are now upstream in d06637b27 and
need no reapplication. The remainder, which are Impala-only
integration points not part of Kudu proper, are reapplied here:
- security/init.cc, util/flags.cc, util/logging.cc: declare (rather
than define) flags that Impala itself defines in
common/global-flags.cc, and skip BlockSigUSR1() since Impala does
not link Kudu's minidump library.
- security/gssapi.cc: dedicated SPNEGO keytab flag (IMPALA-12318).
- security/test/mini_kdc.cc: hardcode /tmp for the KDC data root,
since GetTestDataDirectory() depends on gmock, which Impala's
toolchain lacks.
- util/curl_util.{cc,h}: verify JWKS URL server TLS certs by default
and support a configurable CA bundle (IMPALA-11922).
- util/debug/unwind_safeness.cc: tolerate missing dlopen/dlclose
symbols under IMPALA_SHARED_LIBRARY builds (IMPALA-11640/11641).
- util/web_callback_registry.h: source_socket/source_user fields used
by the webserver (IMPALA-9182, IMPALA-10779).
- rpc/transfer.cc: hide --rpc_max_message_size from --help.
Assisted-by: Claude Sonnet 5 (GitHub Copilot)
Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/kudu/rpc/transfer.cc
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/security/gssapi.cc
M be/src/kudu/security/init.cc
M be/src/kudu/security/test/mini_kdc.cc
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
M be/src/kudu/util/debug/unwind_safeness.cc
M be/src/kudu/util/flags.cc
M be/src/kudu/util/logging.cc
M be/src/kudu/util/web_callback_registry.h
13 files changed, 162 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/24938/2
--
To view, visit http://gerrit.cloudera.org:8080/24938
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2aba8fb89f13aa14d7c1a7b800b9aeee24387041
Gerrit-Change-Number: 24938
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>