You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 02:58:09 UTC
[GitHub] [arrow] rok opened a new pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
rok opened a new pull request #12372:
URL: https://github.com/apache/arrow/pull/12372
This is to resolve [ARROW-14825](https://issues.apache.org/jira/browse/ARROW-14825).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034835077
OK, I see. For consistency with `us_week`, could then also call it `us_year`? Or is that too vague?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274
Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3a4e8692a8e40b3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5e950821761b4a328315f7579af61509...30b508cba8a449b7b8dd563abc2a7a9c/)
[Finished :arrow_down:2.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ab1f4323a3e44cfea5f3c2b045b54e89...a8330f54f5dd42969c8ea3bd53787626/)
[Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8c38997cd01c4520a69c60a80d2ea82a...7678e6bcf32440b8abe130b7863ed058/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4bdcb82de62d40da8ac6380229b86d24...b3e3c975298d4e119eca3611113b296c/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274
Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3a4e8692a8e40b3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5e950821761b4a328315f7579af61509...30b508cba8a449b7b8dd563abc2a7a9c/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ab1f4323a3e44cfea5f3c2b045b54e89...a8330f54f5dd42969c8ea3bd53787626/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8c38997cd01c4520a69c60a80d2ea82a...7678e6bcf32440b8abe130b7863ed058/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4bdcb82de62d40da8ac6380229b86d24...b3e3c975298d4e119eca3611113b296c/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12372:
URL: https://github.com/apache/arrow/pull/12372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1033292631
https://issues.apache.org/jira/browse/ARROW-14825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034954144
The "us_week" was also a new invented name at the time? (or is that used elsewhere)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034187751
us_year seems to better in that regard. (Looking it up - it turns out "epiweek" means something different in the US vs the rest of the world? Oof.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok edited a comment on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034223227
@lidavidm Switched to `us_epiyear`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034267230
Ah, the function doc description needs to be line-wrapped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034965440
> The "us_week" was also a new invented name at the time? (or is that used elsewhere)
So was `assume_timezone`. I suppose we've crossed that threshold. I'll change to `us_year`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034996263
@jorisvandenbossche done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1033293340
Would `us_year` be a better name as it's consistent with already present `us_week` name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274
Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3a4e8692a8e40b3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5e950821761b4a328315f7579af61509...30b508cba8a449b7b8dd563abc2a7a9c/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ab1f4323a3e44cfea5f3c2b045b54e89...a8330f54f5dd42969c8ea3bd53787626/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8c38997cd01c4520a69c60a80d2ea82a...7678e6bcf32440b8abe130b7863ed058/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4bdcb82de62d40da8ac6380229b86d24...b3e3c975298d4e119eca3611113b296c/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274
Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3a4e8692a8e40b3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5e950821761b4a328315f7579af61509...30b508cba8a449b7b8dd563abc2a7a9c/)
[Finished :arrow_down:2.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ab1f4323a3e44cfea5f3c2b045b54e89...a8330f54f5dd42969c8ea3bd53787626/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8c38997cd01c4520a69c60a80d2ea82a...7678e6bcf32440b8abe130b7863ed058/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4bdcb82de62d40da8ac6380229b86d24...b3e3c975298d4e119eca3611113b296c/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034820862
Should there then also be an equivalent `epiweek` kernel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035502274
Benchmark runs are scheduled for baseline = cce55b46395ee351835dbb2864772bfa7ba0eb9c and contender = 54f6c03285943f041fff004b3a4e8692a8e40b3e. 54f6c03285943f041fff004b3a4e8692a8e40b3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5e950821761b4a328315f7579af61509...30b508cba8a449b7b8dd563abc2a7a9c/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ab1f4323a3e44cfea5f3c2b045b54e89...a8330f54f5dd42969c8ea3bd53787626/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8c38997cd01c4520a69c60a80d2ea82a...7678e6bcf32440b8abe130b7863ed058/)
[Finished :arrow_down:0.43% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4bdcb82de62d40da8ac6380229b86d24...b3e3c975298d4e119eca3611113b296c/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034223227
@lidavidm Switched to `us_epiweek`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034272684
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1035534201
Thanks @lidavidm @jorisvandenbossche !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034831641
@jorisvandenbossche we currently have `us_week` and `iso_week`. `us_week` is `us_epiyear`-like. We kind of have two camps here - `iso` and `us/epi`. Very much open to suggestions on naming here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034838852
I don't mind either way. US year seems good because it's consistent with the ISO year definition - year starts with week 1 and it's either from Monday (ISO) for Sunday (US). On the other hand it is inventing a new name :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034205401
> us_year seems to better in that regard. (Looking it up - it turns out "epiweek" means something different in the US vs the rest of the world? Oof.)
Well we're looking to mirror [lubridate's epiyear](https://lubridate.tidyverse.org/reference/year.html) for our R implementation, see [ARROW-14824](https://issues.apache.org/jira/browse/ARROW-14824).
We could also call it us_epiyear to preventively disambiguate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12372: ARROW-14825: [C++] Temporal component extraction function for extracting epiyear
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12372:
URL: https://github.com/apache/arrow/pull/12372#issuecomment-1034211593
us_epiyear makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org