You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/06/10 11:43:58 UTC

[jira] [Commented] (WICKET-3785) CheckGroup's model update should be aligned with ListMultipleChoice

    [ https://issues.apache.org/jira/browse/WICKET-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047107#comment-13047107 ] 

Martin Grigorov commented on WICKET-3785:
-----------------------------------------

// call model.setObject()
+			try
+			{
+				getModel().setObject(collection);
+			}
+			catch (Exception e)
+			{
+				// ignore this exception because it could be that there
+				// is not setter for this collection.
+				log.info("no setter for the property attached to " + this);
+			}

can you elaborate on this ?
why modelchanging/changed don't help ?
and why is this try/catch for ? for PropertyModel? it looks really smelly


> CheckGroup's model update should be aligned with ListMultipleChoice
> -------------------------------------------------------------------
>
>                 Key: WICKET-3785
>                 URL: https://issues.apache.org/jira/browse/WICKET-3785
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.17
>            Reporter: Sven Meier
>              Labels: collections
>         Attachments: CheckGroup.diff
>
>
> Please improve CheckGroup to handle its model updates as ListMultipleChoice does, allowing a model to be notified of changes. See attached patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira