You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ivan Popov (JIRA)" <ji...@apache.org> on 2007/03/01 09:43:50 UTC

[jira] Created: (HARMONY-3269) [jdktools][jpda] Improve cleanup procedure in JDWP agent

[jdktools][jpda] Improve cleanup procedure in JDWP agent
--------------------------------------------------------

                 Key: HARMONY-3269
                 URL: https://issues.apache.org/jira/browse/HARMONY-3269
             Project: Harmony
          Issue Type: Improvement
          Components: JDK
         Environment: Windows, Linux
            Reporter: Ivan Popov
            Priority: Minor


Current implementation of JDWP agent performs full cleanup in VMDeath callback. It includes stopping agent threads and waiting for they to finish. If for whatever reason agent threads are not finished, VM will hang in VMDeath callback, regardless the fact that agent threads are daemon threads and should not cause VM hang. 

In VMDeath callback agent should just close debug session and return form callback without full cleanup. Agent threads will complete cleanup actions and finish. Even if they are not finished for whatever reason, this will not prevent VM from exit.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3269) [jdktools][jpda] Improve cleanup procedure in JDWP agent

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-3269:
------------------------------------------

    Assignee: Gregory Shimansky

> [jdktools][jpda] Improve cleanup procedure in JDWP agent
> --------------------------------------------------------
>
>                 Key: HARMONY-3269
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3269
>             Project: Harmony
>          Issue Type: Improvement
>          Components: JDK
>         Environment: Windows, Linux
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>            Priority: Minor
>
> Current implementation of JDWP agent performs full cleanup in VMDeath callback. It includes stopping agent threads and waiting for they to finish. If for whatever reason agent threads are not finished, VM will hang in VMDeath callback, regardless the fact that agent threads are daemon threads and should not cause VM hang. 
> In VMDeath callback agent should just close debug session and return form callback without full cleanup. Agent threads will complete cleanup actions and finish. Even if they are not finished for whatever reason, this will not prevent VM from exit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3269) [jdktools][jpda] Improve cleanup procedure in JDWP agent

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3269.
----------------------------------------

    Resolution: Fixed

I've reanimated the code that does thread join on shutdown. It seems to be working just fine. Patch committed at 588712.

> [jdktools][jpda] Improve cleanup procedure in JDWP agent
> --------------------------------------------------------
>
>                 Key: HARMONY-3269
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3269
>             Project: Harmony
>          Issue Type: Improvement
>          Components: JDK
>         Environment: Windows, Linux
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>            Priority: Minor
>
> Current implementation of JDWP agent performs full cleanup in VMDeath callback. It includes stopping agent threads and waiting for they to finish. If for whatever reason agent threads are not finished, VM will hang in VMDeath callback, regardless the fact that agent threads are daemon threads and should not cause VM hang. 
> In VMDeath callback agent should just close debug session and return form callback without full cleanup. Agent threads will complete cleanup actions and finish. Even if they are not finished for whatever reason, this will not prevent VM from exit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3269) [jdktools][jpda] Improve cleanup procedure in JDWP agent

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3269.
--------------------------------------


No response, assuming ok.

> [jdktools][jpda] Improve cleanup procedure in JDWP agent
> --------------------------------------------------------
>
>                 Key: HARMONY-3269
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3269
>             Project: Harmony
>          Issue Type: Improvement
>          Components: JDK
>         Environment: Windows, Linux
>            Reporter: Ivan Popov
>            Assignee: Gregory Shimansky
>            Priority: Minor
>
> Current implementation of JDWP agent performs full cleanup in VMDeath callback. It includes stopping agent threads and waiting for they to finish. If for whatever reason agent threads are not finished, VM will hang in VMDeath callback, regardless the fact that agent threads are daemon threads and should not cause VM hang. 
> In VMDeath callback agent should just close debug session and return form callback without full cleanup. Agent threads will complete cleanup actions and finish. Even if they are not finished for whatever reason, this will not prevent VM from exit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.