You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/19 10:04:00 UTC
[GitHub] [incubator-apisix-dashboard] sshniro opened a new pull request
#159: Adding script to verify commit message
sshniro opened a new pull request #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159
Resolves #140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-607194234
Sorry we can't merge it because it doesn't work on my Mac, but don't worry, just take your time :) We can continue on this when the virus got away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] sshniro closed pull request #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
sshniro closed pull request #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-601647559
Thanks, and please add the License header to this file, for we are referencing this file from `https://github.com/vuejs/vue-next/blob/master/scripts/verifyCommit.js`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-606727242
Any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-606967503
Hi @juzhiyuan , due to the work from home situation I could not get my hands on to a mac to resolve this issue. Shall we merge this after the license header update and keep a separate issue for mac?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-601476789
Thanks! I will have a try today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #159: Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#discussion_r395574388
##########
File path: scripts/verifyCommit.js
##########
@@ -0,0 +1,26 @@
+// Invoked on the commit-msg git hook by yorkie.
Review comment:
There should be the same as the origin repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #159: Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#discussion_r395574682
##########
File path: scripts/verifyCommit.js
##########
@@ -0,0 +1,26 @@
+// Invoked on the commit-msg git hook by yorkie.
+
+const chalk = require('chalk');
+const msgPath = process.env.GIT_PARAMS;
Review comment:
`msgPath` is undefined on my MacOS, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-607811516
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #159:
Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-607710799
Okay @juzhiyuan I'm currently closing the PR so anyone wishes are open to fixing this. I will try to attempt another issue from the backlog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] sshniro commented on a change in pull
request #159: Adding script to verify commit message
Posted by GitBox <gi...@apache.org>.
sshniro commented on a change in pull request #159: Adding script to verify commit message
URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#discussion_r396946029
##########
File path: scripts/verifyCommit.js
##########
@@ -0,0 +1,26 @@
+// Invoked on the commit-msg git hook by yorkie.
+
+const chalk = require('chalk');
+const msgPath = process.env.GIT_PARAMS;
Review comment:
sure @juzhiyuan I will check this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services