You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/07/01 13:57:41 UTC
[GitHub] [storm] kishorvpatil commented on a change in pull request #3295: STORM-3660: Remove use of queues for updating credentials
kishorvpatil commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r448381511
##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -124,6 +126,7 @@
protected int idToTaskBase;
protected String hostname;
private static final double msDurationFactor = 1.0 / TimeUnit.MILLISECONDS.toNanos(1);
+ protected boolean needToRefreshCreds = true;
Review comment:
Addressed
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
##########
@@ -152,6 +153,7 @@
private final AtomicLong nextLoadUpdate = new AtomicLong(0);
private final boolean trySerializeLocal;
private final Collection<IAutoCredentials> autoCredentials;
+ AtomicReference<Credentials> credentialsAtom;
Review comment:
Addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org