You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/11/04 16:17:54 UTC
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1327
[FLINK-2966][web-dashboard] Improve the way job duration is reported.
Duration is now reported in the following manner:
< 1 s: as ms, *eg.* 359ms
[1 s, 1 m): as it is, *eg.* 20s
[1 m, 1 h): x m y s, *eg.* 5m 10s
[1 h, 1 d): x h y m, *eg.* 3h 9m [shows seconds too on hovering]
>=1 d: x d y h, *eg.* 5d 2h [shows minutes and seconds too on hovering]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink 2966_durations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1327
----
commit 063c41eb1444a5e4ea62c44954e69743ca089d97
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-11-04T15:04:48Z
[FLINK-2966][web-dashboard] Improve the way job duration is reported.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1327#issuecomment-154159578
Rebased to current master. Should be good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1327#issuecomment-154025813
PR looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1327#discussion_r43997949
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee ---
@@ -28,6 +28,32 @@ angular.module('flinkApp')
amDurationFormatExtendedFilter
+.filter "humanizeDuration", ->
--- End diff --
Myself. And that's a little offensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1327#discussion_r43998970
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee ---
@@ -28,6 +28,32 @@ angular.module('flinkApp')
amDurationFormatExtendedFilter
+.filter "humanizeDuration", ->
--- End diff --
Sorry that I've asked about this. As a committer I have to make sure we properly mark copied code, and this functionality is something very commonly used, and I'm sure there are plenty of implementations of this around in the web.
To be honest, I would have probably copied it from somewhere. That's why I was checking, just to make sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1327#issuecomment-154123489
Thanks. Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1327#issuecomment-155133555
@mxm , rebased. Should be good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1327#discussion_r43999159
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee ---
@@ -28,6 +28,32 @@ angular.module('flinkApp')
amDurationFormatExtendedFilter
+.filter "humanizeDuration", ->
--- End diff --
Fair enough. But since the functionality required here is little bit unusual [two types of strings], it made sense to write the code instead of using even a direct `moment.duration()` function call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1327#discussion_r43997592
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee ---
@@ -28,6 +28,32 @@ angular.module('flinkApp')
amDurationFormatExtendedFilter
+.filter "humanizeDuration", ->
--- End diff --
did you write this yourself or copy it from somewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2966][web-dashboard] Improve the way jo...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1327#issuecomment-155119995
Could you rebase again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---