You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2017/11/07 19:49:49 UTC
[lang] Remove unnecessary testing comments (closes #305)
Repository: commons-lang
Updated Branches:
refs/heads/master 425d8085c -> 20de433aa
Remove unnecessary testing comments (closes #305)
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/20de433a
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/20de433a
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/20de433a
Branch: refs/heads/master
Commit: 20de433aa24957e40d974b87aba54ae0688500ed
Parents: 425d808
Author: Haoliang Quan <ha...@gmail.com>
Authored: Sat Nov 4 22:04:24 2017 -0700
Committer: pascalschumacher <pa...@gmx.net>
Committed: Tue Nov 7 20:49:42 2017 +0100
----------------------------------------------------------------------
.../org/apache/commons/lang3/math/Fraction.java | 3 ---
.../apache/commons/lang3/CharUtilsPerfRun.java | 6 -----
.../apache/commons/lang3/StringUtilsTest.java | 1 -
.../lang3/text/ExtendedMessageFormatTest.java | 1 -
.../commons/lang3/time/DateFormatUtilsTest.java | 28 --------------------
5 files changed, 39 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/20de433a/src/main/java/org/apache/commons/lang3/math/Fraction.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/math/Fraction.java b/src/main/java/org/apache/commons/lang3/math/Fraction.java
index 0ce5bed..0924ac9 100644
--- a/src/main/java/org/apache/commons/lang3/math/Fraction.java
+++ b/src/main/java/org/apache/commons/lang3/math/Fraction.java
@@ -269,7 +269,6 @@ public final class Fraction extends Number implements Comparable<Fraction> {
double delta1, delta2 = Double.MAX_VALUE;
double fraction;
int i = 1;
- // System.out.println("---");
do {
delta1 = delta2;
a2 = (int) (x1 / y1);
@@ -279,7 +278,6 @@ public final class Fraction extends Number implements Comparable<Fraction> {
denom2 = a1 * denom1 + denom0;
fraction = (double) numer2 / (double) denom2;
delta2 = Math.abs(value - fraction);
- // System.out.println(numer2 + " " + denom2 + " " + fraction + " " + delta2 + " " + y1);
a1 = a2;
x1 = x2;
y1 = y2;
@@ -288,7 +286,6 @@ public final class Fraction extends Number implements Comparable<Fraction> {
numer1 = numer2;
denom1 = denom2;
i++;
- // System.out.println(">>" + delta1 +" "+ delta2+" "+(delta1 > delta2)+" "+i+" "+denom2);
} while (delta1 > delta2 && denom2 <= 10000 && denom2 > 0 && i < 25);
if (i == 25) {
throw new ArithmeticException("Unable to convert double to fraction");
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/20de433a/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java b/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java
index 1886d0b..925d05b 100644
--- a/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java
+++ b/src/test/java/org/apache/commons/lang3/CharUtilsPerfRun.java
@@ -102,21 +102,15 @@ public class CharUtilsPerfRun {
long start;
start = System.currentTimeMillis();
this.printlnTotal("Do nothing", start);
- //System.out.println("Warming up...");
run_CharUtils_isAsciiNumeric(WARM_UP);
- //System.out.println("Measuring...");
start = System.currentTimeMillis();
run_CharUtils_isAsciiNumeric(COUNT);
this.printlnTotal("run_CharUtils_isAsciiNumeric", start);
- //System.out.println("Warming up...");
run_inlined_CharUtils_isAsciiNumeric(WARM_UP);
- //System.out.println("Measuring...");
start = System.currentTimeMillis();
run_inlined_CharUtils_isAsciiNumeric(COUNT);
this.printlnTotal("run_inlined_CharUtils_isAsciiNumeric", start);
- //System.out.println("Warming up...");
run_CharSet(WARM_UP);
- //System.out.println("Measuring...");
start = System.currentTimeMillis();
run_CharSet(COUNT);
this.printlnTotal("run_CharSet", start);
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/20de433a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index 451202e..36f8964 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -2371,7 +2371,6 @@ public class StringUtilsTest {
assertEquals(7, StringUtils.indexOfDifference("i am a machine", "i am a robot"));
assertEquals(-1, StringUtils.indexOfDifference("foo", "foo"));
assertEquals(0, StringUtils.indexOfDifference("i am a robot", "you are a robot"));
- //System.out.println("indexOfDiff: " + StringUtils.indexOfDifference("i am a robot", "not machine"));
}
//-----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/20de433a/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java b/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java
index 6b0f725..823c347 100644
--- a/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java
+++ b/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java
@@ -370,7 +370,6 @@ public class ExtendedMessageFormatTest {
buffer.append(locale);
buffer.append("]");
final MessageFormat mf = createMessageFormat(pattern, locale);
- // System.out.println(buffer + ", result=[" + mf.format(args) +"]");
ExtendedMessageFormat emf = null;
if (locale == null) {
emf = new ExtendedMessageFormat(pattern);
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/20de433a/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java b/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
index 603e7de..1a2f4e9 100644
--- a/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/time/DateFormatUtilsTest.java
@@ -186,34 +186,6 @@ public class DateFormatUtilsTest {
timeZone, june);
}
- /*
- public void testLang312() {
- String pattern = "dd/MM/yyyy";
- String expected = "19/04/1948";
- TimeZone timeZone = TimeZone.getTimeZone("CET");
- Locale locale = Locale.GERMANY;
-
- // show Calendar is good
- Calendar cal = Calendar.getInstance(timeZone, locale);
- cal.set(1948, 3, 19);
- assertEquals(expected, DateFormatUtils.format( cal.getTime(), pattern, timeZone, locale ) );
-
- Date date = new Date(48, 3, 19);
-
- // test JDK
- java.text.SimpleDateFormat sdf = new java.text.SimpleDateFormat(pattern, locale);
- sdf.setTimeZone(timeZone);
-// There's nothing we can do if the JDK fails, so just going to print a warning in this case
-// assertEquals(expected, sdf.format( date ) );
- if( ! expected.equals( sdf.format( date ) ) ) {
- System.out.println("WARNING: JDK test failed - testLang312()");
- }
-
- // test Commons
- assertEquals(expected, DateFormatUtils.format( date, pattern, timeZone, locale ) );
- }
- */
-
@Test
public void testLANG1000() throws Exception {
final String date = "2013-11-18T12:48:05Z";