[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6152: travis: Fix failing travis tests on main

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #6152:
URL: https://github.com/apache/cloudstack/pull/6152#discussion_r832100107



##########
File path: test/integration/component/test_project_limits.py
##########
@@ -736,16 +736,6 @@ def test_04_publicip_per_project(self):
                             True,
                             "Check Public IP state is allocated or not"
                         )
-
-        # Exception should be raised for second Public IP
-        with self.assertRaises(Exception):
-            PublicIPAddress.create(
-                                           self.apiclient,
-                                           zoneid=virtual_machine_1.zoneid,
-                                           services=self.services["server"],
-                                           networkid=network.id,
-                                           projectid=self.project.id
-                                           )

Review comment:
       aren't those part of the test purpose; that it throws an exception when trying to create a public IP?

##########
File path: test/integration/component/test_project_limits.py
##########
@@ -845,7 +835,6 @@ def test_06_volumes_per_project(self):
                          account=self.account.name,
                          domainid=self.account.domainid
                          )
-        self.cleanup.append(self.project_1)

Review comment:
       why shouldn't the project be cleaned?

##########
File path: test/integration/component/test_project_limits.py
##########
@@ -872,7 +861,16 @@ def test_06_volumes_per_project(self):
                             'Running',
                             "Check VM state is Running or not"
                         )
+        self.cleanup.append(virtual_machine_1)
+        networks = Network.list(
+            self.apiclient,
+            projectid=self.project_1.id,
+            listall=True
+        )
+        for network in networks:
+            self.cleanup.append(Network(network.__dict__))
 
+        self.cleanup.append(self.project_1)

Review comment:
       it shouldn't be added to cleanup with so much posibilities of exceptions in between.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org