[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission
URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262284520
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
 ##########
 @@ -231,32 +231,34 @@ public int getMaxSegmentsInNodeLoadingQueue()
   }
 
   /**
-   * Historical nodes list in maintenance mode. Coordinator doesn't assign new segments on those nodes and moves
-   * segments from those nodes according to a specified priority.
+   * List of historical nodes to 'decommission'. Coordinator doesn't assign new segments on those nodes and moves
+   * segments from those nodes according to a specified velocity.
    *
    * @return list of host:port entries
    */
   @JsonProperty
-  public Set<String> getHistoricalNodesInMaintenance()
+  public Set<String> getDecommissioningNodes()
   {
-    return historicalNodesInMaintenance;
+    return decommissioningNodes;
   }
 
   /**
-   * Priority of segments from servers in maintenance. Coordinator takes ceil(maxSegmentsToMove * (priority / 10))
-   * from servers in maitenance during balancing phase, i.e.:
-   * 0 - no segments from servers in maintenance will be processed during balancing
-   * 5 - 50% segments from servers in maintenance
-   * 10 - 100% segments from servers in maintenance
-   * By leveraging the priority an operator can prevent general nodes from overload or decrease maitenance time
-   * instead.
+   * Decommissioning velocity indicates what proportion of balancer 'move' operations out of
+   * {@link CoordinatorDynamicConfig#getMaxSegmentsToMove()} total will be spent towards 'decommissioning' servers
+   * by moving their segments to active servers, instead of normal 'balancing' segments between servers.
+   * Coordinator takes ceil(maxSegmentsToMove * (velocity / 10)) from servers in maitenance during balancing phase:
 
 Review comment:
   oops, missed the typo :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org