You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 01:36:35 UTC

[GitHub] [arrow] cyb70289 commented on a diff in pull request #13902: ARROW-17440: [C++] Support RISC-V architecture

cyb70289 commented on code in PR #13902:
URL: https://github.com/apache/arrow/pull/13902#discussion_r947374868


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -32,6 +32,8 @@ if(NOT DEFINED ARROW_CPU_FLAG)
     set(ARROW_CPU_FLAG "ppc")
   elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "s390x")
     set(ARROW_CPU_FLAG "s390x")
+  elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64")
+    set(ARROW_CPU_FLAG "riscv")

Review Comment:
   No code to handle this flag for riscv? Then looks it's not necessary to set it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org