[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #971: Keep password case-sensitive in kvrocks2redis

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #971:
URL: https://github.com/apache/incubator-kvrocks/pull/971#discussion_r991300744


##########
tools/kvrocks2redis/config.cc:
##########
@@ -89,11 +92,11 @@ Status Config::parseConfigFromString(std::string input) {
     kvrocks_host = args[1];
     // In new versions, we don't use extra port to implement replication
     kvrocks_port = std::stoi(args[2]);
-    if (kvrocks_port <= 0 || kvrocks_port >= 65535) {
+    if (kvrocks_port <= 0 || kvrocks_port > 65535) {

Review Comment:
   The intention of this line is to regard the `65535` as an invalid port. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org