You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/02/03 18:35:12 UTC

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18196


Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................

IMPALA-11106: Make Impala compatible with Iceberg 0.13

Currently we are using deprecated methods from Iceberg API which won't
be in 0.13. We need to switch to the newer methods:

* PartitionSpecVisitor.visit
* HiveCatalog constructor

We are also using SnapshotUtil from the Iceberg Core package. One of its
methods has changed semantically. We shouldn't depend on packages
outside of Iceberg API as they are treated as internal modules.

Testing:
* built Impala with Iceberg 0.13.0 and executed Iceberg-related tests

Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
3 files changed, 22 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18196/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7800/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:49:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18196

to look at the new patch set (#2).

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................

IMPALA-11106: Make Impala compatible with Iceberg 0.13

Currently we are using deprecated methods from Iceberg API which won't
be in 0.13. We need to switch to the newer methods:

* PartitionSpecVisitor.visit
* HiveCatalog constructor

We are also using SnapshotUtil from the Iceberg Core package. One of its
methods has changed semantically. We shouldn't depend on packages
outside of Iceberg API as they are treated as internal modules.

Testing:
* built Impala with Iceberg 0.13.0 and executed Iceberg-related tests

Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
3 files changed, 22 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18196/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18196/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/18196/1/fe/src/main/java/org/apache/impala/service/Frontend.java@a53
PS1, Line 53: 
Can we remove the import?



-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 19:55:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:35:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10096/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 10:39:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................

IMPALA-11106: Make Impala compatible with Iceberg 0.13

Currently we are using deprecated methods from Iceberg API which won't
be in 0.13. We need to switch to the newer methods:

* PartitionSpecVisitor.visit
* HiveCatalog constructor

We are also using SnapshotUtil from the Iceberg Core package. One of its
methods has changed semantically. We shouldn't depend on packages
outside of Iceberg API as they are treated as internal modules.

Testing:
* built Impala with Iceberg 0.13.0 and executed Iceberg-related tests

Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Reviewed-on: http://gerrit.cloudera.org:8080/18196
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHiveCatalog.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
3 files changed, 22 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10092/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 18:59:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 21:26:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:49:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11106: Make Impala compatible with Iceberg 0.13

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18196 )

Change subject: IMPALA-11106: Make Impala compatible with Iceberg 0.13
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18196/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/18196/1/fe/src/main/java/org/apache/impala/service/Frontend.java@a53
PS1, Line 53: 
> Can we remove the import?
Sure, thanks for catching this.



-- 
To view, visit http://gerrit.cloudera.org:8080/18196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a95483ea3ce15af9a344f9da3b7bfb7dea8a10a
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 10:16:12 +0000
Gerrit-HasComments: Yes