You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/14 05:10:13 UTC
[GitHub] [hudi] KnightChess opened a new pull request, #5320: [HUDI-3861] update tblp 'path' when rename table
KnightChess opened a new pull request, #5320:
URL: https://github.com/apache/hudi/pull/5320
## What is the purpose of the pull request
update tblp 'path' when table rename
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1098718599
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a2344729ee3dbfe7ca1aac74933eeb6723658f7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850953428
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
The non `MANAGED` table, why can't it be modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1100886105
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a2344729ee3dbfe7ca1aac74933eeb6723658f7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064)
* 4bcf1fd4db8a14f99fa027971db473a1659fbfe7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1098717258
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a2344729ee3dbfe7ca1aac74933eeb6723658f7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126693844
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r884227306
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
Review Comment:
just like here say https://github.com/apache/hudi/pull/5320#discussion_r854717905
table type can not to distinguish whether to update path, managed table with location also will not update storage path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850952202
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
Add check assertion for non `MANAGED` types, path cannot be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850974829
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
> just consistent with metastore design logic. For **MANGED** table, ms will update storage location automatically when rename table, but **EXTERNAL** will not
Does not automatically update, do HMS synchronization API modification, catalog table refresh can also be satisfied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850971092
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
just consistent with metastore design logic. For **MANGED** table, ms will update storage location automatically when rename table, but **EXTERNAL** will not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101137794
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4bcf1fd4db8a14f99fa027971db473a1659fbfe7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089)
* 051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850953428
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
The non `MANAGED` table gives a new path, why can't it be modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1100886973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a2344729ee3dbfe7ca1aac74933eeb6723658f7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064)
* 4bcf1fd4db8a14f99fa027971db473a1659fbfe7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r873147603
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -194,9 +194,14 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
val oldLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(tableName)).properties.get("path")
spark.sql(s"alter table $tableName rename to $newTableName")
val newLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(newTableName)).properties.get("path")
- assertResult(false)(
- newLocation.equals(oldLocation)
- )
+ if (HoodieSparkUtils.isSpark3_2) {
Review Comment:
only use hoodieCatalog will set path to tblp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126684250
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096)
* 318304964fb808f2d0bffb0b854ab3ff9ad7f27b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654)
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126676426
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096)
* 318304964fb808f2d0bffb0b854ab3ff9ad7f27b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126675687
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096)
* 318304964fb808f2d0bffb0b854ab3ff9ad7f27b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101135233
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4bcf1fd4db8a14f99fa027971db473a1659fbfe7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089)
* 051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r884227057
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
+ test("Test Alter Rename Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
Review Comment:
yes, you are right, I can remove here. Considering the mor table will need other check, for example should we need check _ro and _rt table path, but I think it's better fix in other issue like fix rename mor table, it will be add to check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126900295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655)
* 855eb02e145337afea5b1e9bec95c60ecd282bc8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r873147813
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -47,7 +47,7 @@ case class AlterHoodieTableRenameCommand(
AlterTableRenameCommand(oldName, newName, isView).run(sparkSession)
// update table properties path in every op
- if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ if (hoodieCatalogTable.table.properties.contains("path")) {
Review Comment:
catalogProperties contain tblp and storage props
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1140415986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45af5a6082d240f8b9391ca2b704c2c3249d57a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1140399950
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 855eb02e145337afea5b1e9bec95c60ecd282bc8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663)
* 45af5a6082d240f8b9391ca2b704c2c3249d57a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101175263
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091)
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r851755149
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties: path
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ if (catalogTable.tableType == CatalogTableType.MANAGED) {
Review Comment:
my mistake, the managed table which has be set location alson will not update sds, there is no relationship with managed and external table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101146951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091)
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r854717905
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +45,15 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties path in every op
Review Comment:
@jinxing64 yes, if the table type is external, the path I think will not be update, but if the table type is managed, the path has two situation, update or not depend on if the table set location or not when we create table, and I found it's diff in diff spark vertion, that's why mine ut case judge spark version.
so, I think table type is not the better condition to judge update tblp 'path', maybe has other. For correctness, I overwrite path by sds path in every op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #5320:
URL: https://github.com/apache/hudi/pull/5320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1246128153
@xushiyan see see, modify the test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1140399396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 855eb02e145337afea5b1e9bec95c60ecd282bc8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663)
* 45af5a6082d240f8b9391ca2b704c2c3249d57a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r883469001
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +45,15 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties path in every op
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ val path = catalogTable.storage.locationUri.get.getPath
+ logInfo(s"alter ${oldName} name to ${newName}, update tblp 'path' to ${path}")
Review Comment:
@KnightChess
You thumbed up on this comment. Would you please update the log accordingly ?
From my side, it's also fine to just remove it -- Renaming a table should update the path property by default, it's ok no logging. But it depends on you :)
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
+ test("Test Alter Rename Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
Review Comment:
Many of the current sql tests includes both COW and MOR scenarios. But this PR targeting to resolve the issue of RENAME doesn't bother much with whether it's COW or MOR.
Shall we just test COW, which I believe should be enough?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
Review Comment:
Let's give a better testing name, how about "Test renaming MANAGED and EXTERNAL tables"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1139475311
Hi @KnightChess
Thanks a lot you spent effort resolving the JIRA I opened.
This PR has been here for a while. I give some minor comments and the major change looks good to be.
Please check and decide whether to update and let's move forward !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1098765218
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a2344729ee3dbfe7ca1aac74933eeb6723658f7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126684729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 318304964fb808f2d0bffb0b854ab3ff9ad7f27b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654)
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126668229
hi @KnightChess rebase this pr？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126910787
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 855eb02e145337afea5b1e9bec95c60ecd282bc8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r884227709
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
+ test("Test Alter Rename Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
Review Comment:
> yes, you are right, I can remove here. Considering the mor table will need other check, for example should we need check _ro and _rt table path, but I think it's better fix in other issue like fix rename mor table, it will be add to check here.
I think 🤔 both will better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r854067054
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +45,15 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties path in every op
+ if (hoodieCatalogTable.catalogProperties.contains("path")) {
+ val catalogTable = sparkSession.sessionState.catalog.getTableMetadata(newName)
+ val path = catalogTable.storage.locationUri.get.getPath
+ logInfo(s"alter ${oldName} name to ${newName}, update tblp 'path' to ${path}")
Review Comment:
How about `Alter table name from {oldName} to {newName}, update table property of 'path' to {path}`
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +45,15 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties path in every op
Review Comment:
Shall we check and apply below logic only when it's a 'MANAGED' table -- thus to save some remote calls to HMS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r854069170
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +45,15 @@ class AlterHoodieTableRenameCommand(
// Call AlterTableRenameCommand#run to rename table in meta.
super.run(sparkSession)
+
+ // update table properties path in every op
Review Comment:
Shall we check and apply below logic only when it's a 'MANAGED' table -- thus to save some remote calls to HMS when type is 'EXTERNAL'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1245264957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
}, {
"hash" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45af5a6082d240f8b9391ca2b704c2c3249d57a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999)
* 5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1245322670
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
}, {
"hash" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11325",
"triggerID" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 45af5a6082d240f8b9391ca2b704c2c3249d57a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999)
* 5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11325)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1098743224
@leesf cc :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1100901297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4bcf1fd4db8a14f99fa027971db473a1659fbfe7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101139454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1101276548
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126894380
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655)
* 855eb02e145337afea5b1e9bec95c60ecd282bc8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r966357792
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -194,9 +194,14 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
val oldLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(tableName)).properties.get("path")
spark.sql(s"alter table $tableName rename to $newTableName")
val newLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(newTableName)).properties.get("path")
- assertResult(false)(
- newLocation.equals(oldLocation)
- )
+ if (HoodieSparkUtils.isSpark3_2) {
Review Comment:
@KnightChess spark 3.3 is supported. this also applies to 3.3 right?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala:
##########
@@ -169,4 +168,77 @@ class TestAlterTable extends HoodieSparkSqlTestBase {
}
}
}
+
+ test("Test Alter Rename Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ // Create table
+ spark.sql(
+ s"""
+ |create table $tableName (
+ | id int,
+ | name string,
+ | price double,
+ | ts long
+ |) using hudi
+ | tblproperties (
+ | type = '$tableType',
+ | primaryKey = 'id',
+ | preCombineField = 'ts'
+ | )
+ """.stripMargin)
+
+ // alter table name.
+ val newTableName = s"${tableName}_1"
+ val oldLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(tableName)).properties.get("path")
+ spark.sql(s"alter table $tableName rename to $newTableName")
+ val newLocation = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(newTableName)).properties.get("path")
+ if (HoodieSparkUtils.isSpark3_2) {
+ assertResult(false)(
+ newLocation.equals(oldLocation)
+ )
+ } else {
+ assertResult(None) (oldLocation)
+ assertResult(None) (newLocation)
+ }
+
+
+ // Create table with location
+ val locTableName = s"${tableName}_loc"
+ val tablePath = s"${tmp.getCanonicalPath}/$locTableName"
+ spark.sql(
+ s"""
+ |create table $locTableName (
+ | id int,
+ | name string,
+ | price double,
+ | ts long
+ |) using hudi
+ | location '$tablePath'
+ | tblproperties (
+ | type = '$tableType',
+ | primaryKey = 'id',
+ | preCombineField = 'ts'
+ | )
+ """.stripMargin)
+
+ // alter table name.
+ val newLocTableName = s"${locTableName}_1"
+ val oldLocation2 = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(locTableName))
+ .properties.get("path")
+ spark.sql(s"alter table $locTableName rename to $newLocTableName")
+ val newLocation2 = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(newLocTableName))
+ .properties.get("path")
+ if (HoodieSparkUtils.isSpark3_2) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5320: [HUDI-3861] update tblp 'path' when rename table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1245508088
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8064",
"triggerID" : "2a2344729ee3dbfe7ca1aac74933eeb6723658f7",
"triggerType" : "PUSH"
}, {
"hash" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8089",
"triggerID" : "4bcf1fd4db8a14f99fa027971db473a1659fbfe7",
"triggerType" : "PUSH"
}, {
"hash" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8091",
"triggerID" : "051d2951b69d9ba3ccdcbf5ddbe1ee6c1a1585f1",
"triggerType" : "PUSH"
}, {
"hash" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096",
"triggerID" : "81f59f6d17f2b0b0e26243d2ea49b1166af8a546",
"triggerType" : "PUSH"
}, {
"hash" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654",
"triggerID" : "318304964fb808f2d0bffb0b854ab3ff9ad7f27b",
"triggerType" : "PUSH"
}, {
"hash" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655",
"triggerID" : "b0064e9b4c46e6bb2398eddd3a5161c53ac62421",
"triggerType" : "PUSH"
}, {
"hash" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8663",
"triggerID" : "855eb02e145337afea5b1e9bec95c60ecd282bc8",
"triggerType" : "PUSH"
}, {
"hash" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8999",
"triggerID" : "45af5a6082d240f8b9391ca2b704c2c3249d57a1",
"triggerType" : "PUSH"
}, {
"hash" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11325",
"triggerID" : "5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5227cf5a5f43dbf2e7a17a71a33df1ef790cfc74 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11325)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org