You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2015/03/04 02:31:57 UTC
svn commit: r1663842 - /subversion/trunk/tools/dist/backport.pl
Author: danielsh
Date: Wed Mar 4 01:31:57 2015
New Revision: 1663842
URL: http://svn.apache.org/r1663842
Log:
backport.pl: Track a backwards-incompatible Perl language change.
* tools/dist/backport.pl
(): Explicitly require version v5.10.0. (Older Perls would not have worked
anyway since they lack the 'say' feature which this script also requires.)
(warnings): Disable experimental::smartmatch warnings under Perl v5.20.1
and earlier.
Modified:
subversion/trunk/tools/dist/backport.pl
Modified: subversion/trunk/tools/dist/backport.pl
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1663842&r1=1663841&r2=1663842&view=diff
==============================================================================
--- subversion/trunk/tools/dist/backport.pl (original)
+++ subversion/trunk/tools/dist/backport.pl Wed Mar 4 01:31:57 2015
@@ -3,7 +3,16 @@ use warnings;
use strict;
use feature qw/switch say/;
-#no warnings 'experimental::smartmatch';
+use v5.10.0; # needed for $^V
+
+# The given/when smartmatch facility, introduced in Perl v5.10, was made
+# experimental and "subject to change" in v5.18 (see perl5180delta). Every
+# use of it now triggers a warning.
+#
+# As of Perl v5.20.1, the semantics of given/when provided by Perl are
+# compatible with those expected by the script, so disable the warning for
+# those Perls.
+no if $^V le v5.20.1, warnings => 'experimental::smartmatch';
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
Re: svn commit: r1663842 - /subversion/trunk/tools/dist/backport.pl
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Branko Čibej wrote on Wed, Mar 04, 2015 at 14:35:02 +0100:
> On 04.03.2015 02:31, danielsh@apache.org wrote:
> > +use v5.10.0; # needed for $^V
> > +
> > +# The given/when smartmatch facility, introduced in Perl v5.10, was made
> > +# experimental and "subject to change" in v5.18 (see perl5180delta). Every
> > +# use of it now triggers a warning.
> > +#
> > +# As of Perl v5.20.1, the semantics of given/when provided by Perl are
> > +# compatible with those expected by the script, so disable the warning for
> > +# those Perls.
> > +no if $^V le v5.20.1, warnings => 'experimental::smartmatch';
> >
> > # Licensed to the Apache Software Foundation (ASF) under one
> > # or more contributor license agreements. See the NOTICE file
>
> The svn-backport-conflicts bots are red across the board since this
> commit. The error is:
>
> Unknown warnings category 'experimental::smartmatch' at ./.svn/backport.pl line 15
> BEGIN failed--compilation aborted at ./.svn/backport.pl line 15.
Thanks, r1664148.
Re: svn commit: r1663842 - /subversion/trunk/tools/dist/backport.pl
Posted by Branko Čibej <br...@wandisco.com>.
On 04.03.2015 02:31, danielsh@apache.org wrote:
> Author: danielsh
> Date: Wed Mar 4 01:31:57 2015
> New Revision: 1663842
>
> URL: http://svn.apache.org/r1663842
> Log:
> backport.pl: Track a backwards-incompatible Perl language change.
>
> * tools/dist/backport.pl
> (): Explicitly require version v5.10.0. (Older Perls would not have worked
> anyway since they lack the 'say' feature which this script also requires.)
> (warnings): Disable experimental::smartmatch warnings under Perl v5.20.1
> and earlier.
>
> Modified:
> subversion/trunk/tools/dist/backport.pl
>
> Modified: subversion/trunk/tools/dist/backport.pl
> URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1663842&r1=1663841&r2=1663842&view=diff
> ==============================================================================
> --- subversion/trunk/tools/dist/backport.pl (original)
> +++ subversion/trunk/tools/dist/backport.pl Wed Mar 4 01:31:57 2015
> @@ -3,7 +3,16 @@ use warnings;
> use strict;
> use feature qw/switch say/;
>
> -#no warnings 'experimental::smartmatch';
> +use v5.10.0; # needed for $^V
> +
> +# The given/when smartmatch facility, introduced in Perl v5.10, was made
> +# experimental and "subject to change" in v5.18 (see perl5180delta). Every
> +# use of it now triggers a warning.
> +#
> +# As of Perl v5.20.1, the semantics of given/when provided by Perl are
> +# compatible with those expected by the script, so disable the warning for
> +# those Perls.
> +no if $^V le v5.20.1, warnings => 'experimental::smartmatch';
>
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
The svn-backport-conflicts bots are red across the board since this
commit. The error is:
Unknown warnings category 'experimental::smartmatch' at ./.svn/backport.pl line 15
BEGIN failed--compilation aborted at ./.svn/backport.pl line 15.
-- Brane