You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/05/16 14:16:22 UTC

incubator-zeppelin git commit: [ZEPPELIN-853] Fix Last update at X by Y

Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master 742d70cb2 -> 08f70bd1f


[ZEPPELIN-853] Fix Last update at X by Y

### What is this PR for?
This is a hotfix to solve https://issues.apache.org/jira/browse/ZEPPELIN-853. The reason seems to be that new `AuthenticationInfo` field added to paragraph structure doesn't exist in old notebooks and check for non-existence wasn't complete.

### What type of PR is it?
Hot Fix

### Todos
* [x] - fix `if statement`

### What is the Jira issue?
[#853](https://issues.apache.org/jira/browse/ZEPPELIN-853)

### How should this be tested?
Start zeppelin and go to any existing notebook, check console not to have stacktrace mentioned in the issue.

### Screenshots (if appropriate)
Before:
![screenshot from 2016-05-16 21 12 15](https://cloud.githubusercontent.com/assets/1642088/15289839/b5ccffd4-1baf-11e6-888d-5926df79aafa.png)
After:
![screenshot from 2016-05-16 21 34 30](https://cloud.githubusercontent.com/assets/1642088/15289843/bfee079c-1baf-11e6-8e91-59efa5a26133.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Khalid Huseynov <kh...@nflabs.com>

Closes #891 from khalidhuseynov/fix/last-updated-by-x-at-y and squashes the following commits:

e53e4df [Khalid Huseynov] fix if statement


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/08f70bd1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/08f70bd1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/08f70bd1

Branch: refs/heads/master
Commit: 08f70bd1f156c6feb8e85ff0ff05f945c5de856b
Parents: 742d70c
Author: Khalid Huseynov <kh...@nflabs.com>
Authored: Mon May 16 21:37:38 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon May 16 07:17:04 2016 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/08f70bd1/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index 21dd279..b19003f 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -969,7 +969,8 @@ angular.module('zeppelinWebApp')
       return '';
     }
     var user = 'anonymous';
-    if (pdata.authenticationInfo !== null && pdata.authenticationInfo.user !== null) {
+    var authInfo = pdata.authenticationInfo;
+    if (authInfo && authInfo.user) {
       user = pdata.authenticationInfo.user;
     }
     var dateUpdated = (pdata.dateUpdated === null) ? 'unknown' : pdata.dateUpdated;