[GitHub] [geode-benchmarks] balesh2 commented on a change in pull request #119: Confirm and retry AWS instance allocations.

[GitBox <gi...@apache.org>]

balesh2 commented on a change in pull request #119: Confirm and retry AWS instance allocations.
URL: https://github.com/apache/geode-benchmarks/pull/119#discussion_r354601778
 
 

 ##########
 File path: infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
 ##########
 @@ -120,26 +123,36 @@ private static void usage(String s) {
     throw new IllegalStateException(s);
   }
 
-  private static List<String> allocateHosts(List<Tag> tags, int count) {
-    AllocateHostsResponse hosts = ec2.allocateHosts(AllocateHostsRequest.builder()
-        .availabilityZone("us-west-2a")
-        .instanceType(AwsBenchmarkMetadata.instanceType().toString())
-        .quantity(count)
-        .tagSpecifications(TagSpecification.builder()
-            .tags(tags)
-            .resourceType(ResourceType.DEDICATED_HOST)
-            .build())
-        .build());
+  private static List<String> allocateHosts(List<Tag> tags, int count, int timeout)
+      throws InterruptedException {
+    int gotHosts = 0;
+    AllocateHostsResponse hosts;
+
+    Instant end = Instant.now().plus(Duration.ofSeconds(timeout));
+    do {
+      hosts = ec2.allocateHosts(AllocateHostsRequest.builder()
+          .availabilityZone("us-west-2a")
+          .instanceType(AwsBenchmarkMetadata.instanceType().toString())
+          .quantity(count - gotHosts)
+          .tagSpecifications(TagSpecification.builder()
+              .tags(tags)
+              .resourceType(ResourceType.DEDICATED_HOST)
+              .build())
+          .build());
+      gotHosts += hosts.hostIds().size();
+      if (Instant.now().isAfter(end)) {
+        throw new InterruptedException(
+            count + " hosts were not allocated before timeout of " + timeout + " seconds.");
+      }
+    } while (gotHosts < count);
 
 Review comment:
   It could have one but doesn't need it. The reason we have that in the other loop is that the loop is waiting for the instances to become available, so there's no point in checking constantly. In this loop, the allocateHosts call is blocking, so that keeps this from being a hot loop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services