[GitHub] [cloudstack] RodrigoDLopez commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values

[GitBox <gi...@apache.org>]

RodrigoDLopez commented on issue #3681: Validate disk offering IOPS normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681#issuecomment-592730379
 
 
   ## MANUAL TEST ##
   ```
   On global settings:
   vm.disk.bytes.maximum.read.length = 0
   vm.disk.bytes.maximum.write.length = 0
   vm.disk.iops.maximum.read.length = 0
   vm.disk.iops.maximum.write.length = 0
   ```
   
   Testing via API
   * **test 01**
   	bytesreadrate=1000 
   	bytesreadratemax=1000 
   	bytesreadratemaxlength=2000 
   
   	byteswriterate=1000 
   	byteswriteratemax=1000 
   	byteswriteratemaxlength=2000 
   
   	iopsreadrate=1000 
   	iopsreadratemax=1000 
   	iopsreadratemaxlength=2000 
   
   	iopswriterate=1000 
   	iopswriteratemax=1000 
   	iopswriteratemaxlength=2000
   
   **Expected result:** create the offering
   **Result:** All good
   
   * **test 02**
   	Same as test 01, except by:
   	bytesreadratemax=900
   
   **Expected result:** fail during disk offering creation due to bytes_read_rate (1000) > bytes_read_rate_max (900)
   **Result:**  Bytes Read rate (1000) cannot be greater than Bytes Read maximum rate (900)
   
   * **test 03**
   	Same as test 01, except by:
   	byteswriteratemax=900
   	
   **Expected result:** fail during disk offering creation due to bytes_write_rate (1000) > bytes_write_rate_max (900)
   **Result:**  Bytes Write rate (1000) cannot be greater than Bytes Write maximum rate (900)
   
   * **test 04**
   	Same as test 01, except by:
   	iopsreadratemax=900
   	
   **Expected result:** fail during disk offering creation due to iops_read_rate (1000) > iops_read_rate_max (900)
   **Result:**  IOPS Read rate (1000) cannot be greater than IOPS Read maximum rate (900)
   
   * **test 05**
   	Same as test 01, except by:
   	iopswriteratemax=900
   	
   **Expected result:** fail during disk offering creation due to iops_write_rate (1000) > iops_write_rate_max (900)
   **Result:**  IOPS Write rate (1000) cannot be greater than IOPS Write maximum rate (900)
   
   ```
   On global settings:
   vm.disk.bytes.maximum.read.length = 2000
   vm.disk.bytes.maximum.write.length = 2000
   vm.disk.iops.maximum.read.length = 2000
   vm.disk.iops.maximum.write.length = 2000
   ```
   
   * **test 06**
   	same as test 01, except by:
   	bytesreadratemaxlength=2001
   
   **Expected result:** fail during disk offering creation due to bytes_read_rate_max_length (2001) >  vm.disk.bytes.maximum.read.length (2000)
   **Result:** Bytes read max length (2001 seconds) cannot be greater than vm.disk.bytes.maximum.read.length (2000 seconds)
   
   * **test 07**
   	same as test 01, except by:
   	byteswriteratemaxlength=2001
   
   **Expected result:** fail during disk offering creation due to bytes_write_rate_max_length (2001) >  vm.disk.bytes.maximum.write.length (2000)
   **Result:** All good
   
   * **test 08**
   	same as test 01, except by:
   	iopsreadratemaxlegth=2001
   
   **Expected result:** fail during disk offering creation due to iops_read_rate_max_length (2001) >  vm.disk.iops.maximum.read.length (2000)
   **Result:** IOPS read max length (2001 seconds) cannot be greater than vm.disk.iops.maximum.read.length (2000 seconds)
   
   * **test 09**
   	same as test 01, except by:
   	iopswriteratemaxlegth=2001
   
   **Expected result:** fail during disk offering creation due to iops_write_rate_max_length (2001) >  vm.disk.iops.maximum.write.length (2000)
   **Result:** IOPS write max length (2001 seconds) cannot be greater than vm.disk.iops.maximum.write.length (2000 seconds)
   
   The 'test 07' result is all good, except by: it should have failed
   I requested some changes to fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services