You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/16 19:34:43 UTC

[GitHub] [camel-website] psingh587 opened a new pull request #226: Added Translate property to category blog aside items

psingh587 opened a new pull request #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226
 
 
   ![Screenshot from 2020-03-16 16-08-09](https://user-images.githubusercontent.com/51945896/76793442-11b0db00-67eb-11ea-8a85-4435513b9833.png)
   
   
   I have reopened this PR, as i had not pulled the recent changes made in the original repo earlier and made the PR just like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 closed pull request #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
psingh587 closed pull request #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-604407499
 
 
   @psingh587 I'd guess to help with that question we first need to answer the question what's the problem we're addressing with such a change. If it's adding a thing just to add it, I'd avoid adding it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] oscerd commented on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-599979693
 
 
   There's nothing you need to fix. Look at the logs of the CI.
   
   [2020-03-16T19:48:08.705Z] ERROR 2020/03/16 19:48:08 Failed to get JSON resource "https://issues.apache.org/jira/rest/api/latest/search?jql=fixVersion=12346526&fields=issuetype,summary": Get https://issues.apache.org/jira/rest/api/latest/search?jql=fixVersion=12346526&fields=issuetype,summary: net/http: TLS handshake timeout

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-599961083
 
 
   @zregvart  how do i fix this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 edited a comment on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-603399551
 
 
   > I'm not a fan of such transformations. I guess the question here is do we need this?
   
   Hi @zregvart ,
   I guess yes, it looks a little gimmicky to me too. I was actually thinking to make it a little appealing and not static, at least the buttons and links could possibly have some animations maybe. What else could be done here? Or is it better to leave them as they are?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-603399551
 
 
   > I'm not a fan of such transformations. I guess the question here is do we need this?
   
   Hi @zregvart ,
   I guess yes, it looks a little gimmicky to me too. I was actually thinking to make it a not static, at least the buttons and links could possibly have some animations maybe. What else could be done here? Or is it better to leave them as it is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 edited a comment on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
psingh587 edited a comment on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-603399551
 
 
   > I'm not a fan of such transformations. I guess the question here is do we need this?
   
   Hi @zregvart ,
   I guess yes, it looks a little gimmicky to me too. I was actually thinking to make it a little appealing and not static, at least the buttons and links could possibly have some animations maybe. What else could be done here? Or is it better to leave them as it is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #226: Added Translate property to category blog aside items

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #226: Added Translate property to category blog aside items
URL: https://github.com/apache/camel-website/pull/226#issuecomment-602578020
 
 
   Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-226/Preview/blog/).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services