You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 07:08:21 UTC

[GitHub] [arrow] chaokunyang opened a new pull request #7937: [ARROW-9700] fix create_library_symlinks for macos

chaokunyang opened a new pull request #7937:
URL: https://github.com/apache/arrow/pull/7937


   Fix create_library_symlinks for macos


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673849791


   Why this pr got closed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673204636


   Thanks.
   How about this?
   
   ```diff
   diff --git a/python/pyarrow/__init__.py b/python/pyarrow/__init__.py
   index e011ee74f..9e22cc013 100644
   --- a/python/pyarrow/__init__.py
   +++ b/python/pyarrow/__init__.py
   @@ -380,7 +380,7 @@ def create_library_symlinks():
            bundled_libs = glob.glob(_os.path.join(package_cwd, '*.*.dylib'))
    
            def get_symlink_path(hard_path):
   -            return '.'.join((hard_path.split('.')[0], 'dylib'))
   +            return '.'.join((hard_path.rsplit('.', 2)[0], 'dylib'))
    
        for lib_hard_path in bundled_libs:
            symlink_path = get_symlink_path(lib_hard_path)
   ```
   
   This will be simpler than your implementation and similar to the implementaion for `'linux'`. Similar implementation will be easy to maintain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673228598


   Hi @kou , I've updated the pr, could you help review again and merge it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673418963


   SGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang removed a comment on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang removed a comment on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673202525


   ```
   def get_symlink_path(hard_path):
       return '.'.join((hard_path.split('.')[0], 'dylib'))
   ```
   `get_symlink_path("/Users/xxx/anaconda3/envs/ray/lib/python3.6/site-packages/pyarrow/libarrow.100.dylib")` got `/Users/xxx/anaconda3/envs/ray/lib/python3.dylib`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang removed a comment on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang removed a comment on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673849791


   Why this pr got closed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673202525


   ```
   def get_symlink_path(hard_path):
       return '.'.join((hard_path.split('.')[0], 'dylib'))
   ```
   `get_symlink_path("/Users/xxx/anaconda3/envs/ray/lib/python3.6/site-packages/pyarrow/libarrow.100.dylib")` got `/Users/xxx/anaconda3/envs/ray/lib/python3.dylib`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673116538


   Could you show a `.dylib` path that causes this problem?
   
   It seems that the current implementation works well for `libarrow.100.dylib` that is included in https://files.pythonhosted.org/packages/7c/b3/7d06f2959206aae325dfb9efea911d688ccfe3405c10c3a03c2f8126564f/pyarrow-1.0.0-cp38-cp38-manylinux1_x86_64.whl .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
kou closed pull request #7937:
URL: https://github.com/apache/arrow/pull/7937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chaokunyang commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
chaokunyang commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673202954


   ```python
   def get_symlink_path(hard_path):
       return '.'.join((hard_path.split('.')[0], 'dylib'))
   ```
   `get_symlink_path("/Users/xxx/anaconda3/envs/ray/lib/python3.6/site-packages/pyarrow/libarrow.100.dylib")` got `/Users/xxx/anaconda3/envs/ray/lib/python3.dylib`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-672959452


   https://issues.apache.org/jira/browse/ARROW-9700


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7937: ARROW-9700: [Python] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-673239409


   @kszucs It seems that this should be included into 1.0.1. What do you think about this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7937: [ARROW-9700] fix create_library_symlinks for macos

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7937:
URL: https://github.com/apache/arrow/pull/7937#issuecomment-672681222


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org