[GitHub] caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

[gi...@git.apache.org]

caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image
URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316344903
 
 
   @jiazhai 
   It's ok to have such a structure. We need it in order to provide docker images of older versions. Having a CentOS image is ok too, when licensing concerns not allow to run alpine. Take a look at other "official" images, you will see that no images provide only one tag. The [postgres](https://hub.docker.com/_/postgres/) example is quite complete.
   
   It's normal that centos and alpine version shares a lot of code, unfortunately, but I don't see any solution to that. To reduce code replication between releases of the same os, I think in the end @sijie solution to generate versions from a template is the best.
   
   @sijie 
   I missed your question: "for current version, it might be worth having a latest directory. when we cut a release, we copy the latest directory to the targeted release directory. for example, in 4.5.0, we can copy latest to a directory 4.5.0. Is that doable?"
   It is possible and simple to create an "onbuild" docker build (not to be confused with "latest" that in docker means the latest stable version) if maybe in jenkins job we run the "package" target and then we publish the produced packet somewhere. Otherwise it's still possible to create a docker build that checkout the last commit (at risk to have something broken, with jenkins we can publish the package only if all tests pass), package it, unpack it in the usual dir and then clean everything it's not needed runtime, but it's require some effort, doubled by alpine + centos dichotomy, so it's better to create a dedicated issue.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services