You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/09/01 00:23:33 UTC
[jira] Created: (CASSANDRA-403) inline BatchMutation struct to make
batch_insert look more like the rest of the api
inline BatchMutation struct to make batch_insert look more like the rest of the api
-----------------------------------------------------------------------------------
Key: CASSANDRA-403
URL: https://issues.apache.org/jira/browse/CASSANDRA-403
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
batch_insert is the only column-oriented method that doesn't take a "string key" argument, because in this case it's combined into BatchMutation. This violates the principle of least surprise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-403) inline BatchMutation struct to
make batch_insert look more like the rest of the api
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749883#action_12749883 ]
Hudson commented on CASSANDRA-403:
----------------------------------
Integrated in Cassandra #184 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/184/])
inline BatchMutation into batch_insert params
patch by jbellis; reviewed by Evan Weaver for
> inline BatchMutation struct to make batch_insert look more like the rest of the api
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-403
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 403.patch
>
>
> batch_insert is the only column-oriented method that doesn't take a "string key" argument, because in this case it's combined into BatchMutation. This violates the principle of least surprise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-403) inline BatchMutation struct to make
batch_insert look more like the rest of the api
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-403:
-------------------------------------
Attachment: 403.patch
Getting rid of wrapper structs feels good and will make life better for people using raw Thrift.
When we add CASSANDRA-336 (for 0.5) we will probably add a BatchMutation struct back or something similar to it, for a new method that is to batch_insert what multiget_slice is to get_slice.
> inline BatchMutation struct to make batch_insert look more like the rest of the api
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-403
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 403.patch
>
>
> batch_insert is the only column-oriented method that doesn't take a "string key" argument, because in this case it's combined into BatchMutation. This violates the principle of least surprise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-403) inline BatchMutation struct to
make batch_insert look more like the rest of the api
Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749665#action_12749665 ]
Evan Weaver commented on CASSANDRA-403:
---------------------------------------
Sure, +1
> inline BatchMutation struct to make batch_insert look more like the rest of the api
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-403
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 403.patch
>
>
> batch_insert is the only column-oriented method that doesn't take a "string key" argument, because in this case it's combined into BatchMutation. This violates the principle of least surprise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-403) inline BatchMutation struct to
make batch_insert look more like the rest of the api
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-403:
----------------------------------------
Assignee: Jonathan Ellis
> inline BatchMutation struct to make batch_insert look more like the rest of the api
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-403
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
>
> batch_insert is the only column-oriented method that doesn't take a "string key" argument, because in this case it's combined into BatchMutation. This violates the principle of least surprise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.