You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Owen-CH-Leung (via GitHub)" <gi...@apache.org> on 2023/11/01 13:12:52 UTC

Re: [PR] Add k8s recommended labels [airflow]

Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1788933112

   > > I think you should also have to consider `Label selectors`.
   > 
   > This means replacing the previous labels with the K8S recommended labels in `label selector`s. There may be problems due to replacement, so I think it would be good idea to leave it as is. (I think we can replace labels when the chart major version is bumped) I'd like to hear what others think!
   > 
   > Please add recommemded labels to the `chart/files/pod-template-file.kubernetes-helm-yaml` file as well!
   > 
   > Thank you for going above and beyond!
   
   No problem =). Added recommended labels to `chart/files/pod-template-file.kubernetes-helm-yaml`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org