You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2008/08/25 17:17:44 UTC

[jira] Resolved: (SOLR-724) CoreDescriptor.{get,set}CoreProperties should probably not be public (but package private)

     [ https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-724.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3
         Assignee: Shalin Shekhar Mangar

Committed revision 688751.

Bowing down to public demand :-)

Changing the methods to package private to insulate the public API from internal changes.

> CoreDescriptor.{get,set}CoreProperties should probably not be public (but package private)
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-724
>                 URL: https://issues.apache.org/jira/browse/SOLR-724
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.3
>
>
> Exposing them precludes being ever able to fill the CoreDescriptor with property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.