You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/04 04:17:47 UTC
[jclouds] Unasync tree that starts with openstack legacy (#542)
There are a number of interdependencies on old openstack code. Eventhough there is a schedule to remove the Rackspace CloudServers and CloudFiles providers, we are better off asyncing now as they are part of a tree that is preventing us from completing the unasync effort.
This pull request removes the async interfaces from all of the dependencies in core. This includes old openstack, new openstack (as was still referenced by cloudservers, cloudfiles and hpcloud), swift, cloudservers, cloudfiles and hpcloud.
With this merged, we are *finally* unlocked to complete the un-async effort, which will dramatically decomplicate core.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds acole.openstack-legacy.unasync
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/542
-- Commit Summary --
* JCLOUDS-296 unasync legacy keystone used by swift derivatives and cloudfiles.
* key
* JCLOUDS-296 unasync legacy swift provider.
* JCLOUDS-296 unasync legacy cloudfiles provider.
* JCLOUDS-296 unasync legacy cloudservers provider.
* JCLOUDS-296 unasync hpcloud storage provider.
-- File Changes --
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/CloudFilesApiMetadata.java (30)
D apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/CloudFilesAsyncClient.java (214)
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/CloudFilesClient.java (138)
D apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/blobstore/CloudFilesAsyncBlobStore.java (98)
M apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/blobstore/config/CloudFilesBlobStoreContextModule.java (3)
R apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/config/CloudFilesHttpApiModule.java (19)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/CloudFilesClientLiveTest.java (2)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/blobstore/CloudFilesBlobSignerExpectTest.java (6)
M apis/cloudfiles/src/test/java/org/jclouds/cloudfiles/config/CloudFilesRestClientModuleTest.java (12)
M apis/cloudservers/src/main/java/org/jclouds/cloudservers/CloudServersApiMetadata.java (28)
D apis/cloudservers/src/main/java/org/jclouds/cloudservers/CloudServersAsyncClient.java (387)
M apis/cloudservers/src/main/java/org/jclouds/cloudservers/CloudServersClient.java (240)
M apis/cloudservers/src/main/java/org/jclouds/cloudservers/compute/config/CloudServersComputeServiceContextModule.java (4)
R apis/cloudservers/src/main/java/org/jclouds/cloudservers/config/CloudServersHttpApiModule.java (9)
R apis/cloudservers/src/test/java/org/jclouds/cloudservers/CloudServersClientTest.java (118)
M apis/cloudservers/src/test/java/org/jclouds/cloudservers/internal/BaseCloudServersComputeServiceExpectTest.java (10)
M apis/cloudservers/src/test/java/org/jclouds/cloudservers/internal/BaseCloudServersRestClientExpectTest.java (10)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/AuthenticationAsyncApi.java (93)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/KeystoneApiMetadata.java (9)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/KeystoneAsyncApi.java (117)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/KeystoneAuthenticationModule.java (2)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/KeystoneRestClientModule.java (167)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/MappedAuthenticationApiModule.java (40)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminAsyncApi.java (110)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminAsyncApi.java (126)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminAsyncApi.java (137)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminAsyncApi.java (113)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/features/ServiceAsyncApi.java (58)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/features/TenantAsyncApi.java (101)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/features/TokenAsyncApi.java (94)
D apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/features/UserAsyncApi.java (125)
D apis/swift/src/main/java/org/jclouds/openstack/swift/CommonSwiftAsyncClient.java (276)
M apis/swift/src/main/java/org/jclouds/openstack/swift/CommonSwiftClient.java (213)
M apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftApiMetadata.java (45)
D apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftAsyncClient.java (34)
M apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftClient.java (6)
M apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftKeystoneApiMetadata.java (42)
D apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftKeystoneAsyncClient.java (35)
M apis/swift/src/main/java/org/jclouds/openstack/swift/SwiftKeystoneClient.java (6)
D apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/SwiftAsyncBlobStore.java (258)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/SwiftBlobSigner.java (6)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/config/SwiftBlobStoreContextModule.java (9)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/config/TemporaryUrlExtensionModule.java (30)
M apis/swift/src/main/java/org/jclouds/openstack/swift/blobstore/strategy/internal/ParallelMultipartUploadStrategy.java (30)
R apis/swift/src/main/java/org/jclouds/openstack/swift/config/SwiftHttpApiModule.java (26)
R apis/swift/src/main/java/org/jclouds/openstack/swift/config/SwiftKeystoneHttpApiModule.java (17)
R apis/swift/src/main/java/org/jclouds/openstack/swift/extensions/KeystoneTemporaryUrlKeyApi.java (4)
M apis/swift/src/main/java/org/jclouds/openstack/swift/extensions/TemporaryUrlKeyApi.java (39)
D apis/swift/src/main/java/org/jclouds/openstack/swift/extensions/TemporaryUrlKeyAsyncApi.java (62)
M apis/swift/src/test/java/org/jclouds/openstack/swift/CommonSwiftClientTest.java (10)
M apis/swift/src/test/java/org/jclouds/openstack/swift/SwiftClientLiveTest.java (3)
M apis/swift/src/test/java/org/jclouds/openstack/swift/SwiftKeystoneClientLiveTest.java (2)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftBlobSignerExpectTest.java (4)
M apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/SwiftKeystoneBlobSignerExpectTest.java (10)
M apis/swift/src/test/java/org/jclouds/openstack/swift/config/KeystoneStorageEndpointModuleTest.java (2)
D apis/swift/src/test/java/org/jclouds/openstack/swift/internal/StubSwiftAsyncClient.java (224)
M common/openstack/src/main/java/org/jclouds/openstack/config/OpenStackAuthenticationModule.java (5)
D common/openstack/src/main/java/org/jclouds/openstack/internal/OpenStackAuthAsyncClient.java (57)
M common/openstack/src/main/java/org/jclouds/openstack/internal/OpenStackAuthClient.java (6)
D common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/AuthenticationAsyncClient.java (54)
M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/AuthenticationClient.java (11)
M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/config/AuthenticationServiceModule.java (5)
R common/openstack/src/test/java/org/jclouds/openstack/internal/OpenStackAuthClientTest.java (13)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/HPCloudObjectStorageApi.java (50)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/HPCloudObjectStorageApiMetadata.java (54)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/blobstore/HPCloudObjectStorageBlobRequestSigner.java (8)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/blobstore/config/HPCloudObjectStorageBlobStoreContextModule.java (5)
A providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/config/HPCloudObjectStorageHttpApiModule.java (93)
M providers/hpcloud-objectstorage/src/main/java/org/jclouds/hpcloud/objectstorage/extensions/CDNContainerApi.java (98)
M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/HPCloudObjectStorageClientLiveTest.java (2)
M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/blobstore/HPCloudObjectStorageBlobSignerExpectTest.java (10)
M providers/hpcloud-objectstorage/src/test/java/org/jclouds/hpcloud/objectstorage/config/HPCloudObjectStorageEndpointModuleTest.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/542.patch
https://github.com/jclouds/jclouds/pull/542.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #124](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/124/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57892033
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1213](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1213/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57893174
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1701](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1701/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57906083
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1695](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1695/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57898124
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #123](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/123/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57892030
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by Andrew Gaul <no...@github.com>.
> @@ -118,7 +169,12 @@
> * <p/>
> * ACTIVE - QUEUE_RESIZE - ACTIVE (on error)
> */
> - void resizeServer(int id, int flavorId);
> + @POST
> + @QueryParams(keys = "format", values = "json")
> + @Path("/servers/{id}/action")
> + @Produces(APPLICATION_JSON)
> + @Payload("%7B\"resize\":%7B\"flavorId\":{flavorId}%7D%7D")
Clever escape of braces.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542/files#r18427695
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1694](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1694/) ABORTED
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57897225
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by Andrew Gaul <no...@github.com>.
:+1: although I no human can reason about refactors this large!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57895168
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by Adrian Cole <no...@github.com>.
merged into 1.8.x and master
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57896304
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #129](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/129/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57895810
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1218](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1218/) ABORTED
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57916316
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1212](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1212/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57893175
Re: [jclouds] Unasync tree that starts with openstack legacy (#542)
Posted by Adrian Cole <no...@github.com>.
@jdaggett @everett-toews @zack-shoylev
No probs doing this work, despite its arduousness. Certainly would appreciate facilitating the merge by reviews (which hopefully don't ask me to correct old code :) )!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/542#issuecomment-57892043