You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/17 03:39:09 UTC
Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
> On Dec. 18, 2015, 11:04 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 386
> > <https://reviews.apache.org/r/41490/diff/4/?file=1171208#file1171208line386>
> >
> > s/v1DockerImageManifest/manifest/
v2 fixed as well.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/#review111229
-----------------------------------------------------------
On Dec. 18, 2015, 12:11 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41490/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 12:11 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4186
> https://issues.apache.org/jira/browse/MESOS-4186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provisioner: Added test case for docker v1 manifest serialization.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
>
> Diff: https://reviews.apache.org/r/41490/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/#review111229
-----------------------------------------------------------
Ship it!
src/tests/containerizer/provisioner_docker_tests.cpp (line 302)
<https://reviews.apache.org/r/41490/#comment171322>
2 lines apart.
src/tests/containerizer/provisioner_docker_tests.cpp (line 386)
<https://reviews.apache.org/r/41490/#comment171323>
s/v1DockerImageManifest/manifest/
- Jie Yu
On Dec. 18, 2015, 6:58 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41490/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:58 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4186
> https://issues.apache.org/jira/browse/MESOS-4186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provisioner: Added test case for docker v1 manifest serialization.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
>
> Diff: https://reviews.apache.org/r/41490/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 1:31 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp b57ee8681e0861cf93f5dcf9368c004a57df1374
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 12:11 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 10:58 a.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 1:21 a.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 41490: Provisioner: Added test case for docker v1
manifest serialization.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41490/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 1:18 a.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4186
https://issues.apache.org/jira/browse/MESOS-4186
Repository: mesos
Description
-------
Provisioner: Added test case for docker v1 manifest serialization.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41490/diff/
Testing
-------
make check
Thanks,
Gilbert Song