You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by dl...@apache.org on 2001/08/24 17:55:20 UTC

cvs commit: jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/localization Localization.java

dlr         01/08/24 08:55:20

  Modified:    src/services/java/org/apache/fulcrum/localization
                        Localization.java
  Log:
  Marked getService() as final as a hint to the compiler to inline
  method body.
  
  Revision  Changes    Path
  1.2       +2 -2      jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/localization/Localization.java
  
  Index: Localization.java
  ===================================================================
  RCS file: /home/cvs/jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/localization/Localization.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -u -r1.1 -r1.2
  --- Localization.java	2001/08/23 21:21:45	1.1
  +++ Localization.java	2001/08/24 15:55:20	1.2
  @@ -83,7 +83,7 @@
    * Localization.getString(str)
    *
    * @author <a href="mailto:jon@latchkey.com">Jon S. Stevens</a>
  - * @version $Id: Localization.java,v 1.1 2001/08/23 21:21:45 jon Exp $
  + * @version $Id: Localization.java,v 1.2 2001/08/24 15:55:20 dlr Exp $
    */
   public abstract class Localization
   {
  @@ -229,7 +229,7 @@
        *
        * @return the LocalizationService implementation.
        */
  -    protected static LocalizationService getService()
  +    protected static final LocalizationService getService()
       {
           return (LocalizationService) TurbineServices.getInstance()
                   .getService(LocalizationService.SERVICE_NAME);
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/localization Localization.java

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jon Stevens <jo...@latchkey.com> writes:

> on 8/24/01 8:55 AM, "dlr@apache.org" <dl...@apache.org> wrote:
> 
> > dlr         01/08/24 08:55:20
> > 
> > Modified:    src/services/java/org/apache/fulcrum/localization
> >                       Localization.java
> > Log:
> > Marked getService() as final as a hint to the compiler to inline
> > method body.
> > 
> 
> With HotSpot, I don't think this is needed, but ok...

It's not needed with Hotspot (server edition, at least).  I wouldn't
want anyone overriding that method, though, either (it would be
unnecessary).

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: cvs commit: jakarta-turbine-fulcrum/src/services/java/org/apache/fulcrum/localization Localization.java

Posted by Jon Stevens <jo...@latchkey.com>.
on 8/24/01 8:55 AM, "dlr@apache.org" <dl...@apache.org> wrote:

> dlr         01/08/24 08:55:20
> 
> Modified:    src/services/java/org/apache/fulcrum/localization
>                       Localization.java
> Log:
> Marked getService() as final as a hint to the compiler to inline
> method body.
> 

With HotSpot, I don't think this is needed, but ok...

-jon


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org