[jira] [Commented] (DRILL-8049) Make rule names for Iceberg plugin instances unique

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446598#comment-17446598 ] 

ASF GitHub Bot commented on DRILL-8049:
---------------------------------------

vvysotskyi opened a new pull request #2382:
URL: https://github.com/apache/drill/pull/2382


   # [DRILL-8049](https://issues.apache.org/jira/browse/DRILL-8049): Make rule names for Iceberg plugin instances unique
   
   ## Description
   Added generator for format id values. Formats with the same name may be defined in multiple storage plugins, so using the unique id within the convention name to ensure the rule names will be unique for different plugin instances.
   
   ## Documentation
   NA
   
   ## Testing
   Updated tests to check this scenario.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make rule names for Iceberg plugin instances unique
> ---------------------------------------------------
>
>                 Key: DRILL-8049
>                 URL: https://issues.apache.org/jira/browse/DRILL-8049
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.20.0
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Major
>             Fix For: 1.20.0
>
>
> As [~dzamo] noticed, when defining multiple storage plugins with Iceberg format, queries fail with the following error:
> {noformat}
> Caused by: java.lang.AssertionError: Rule's description should be unique; existing rule=VertexDrelConverterRuleICEBERG.iceberg(in:ICEBERG.iceberg,out:LOGICAL); new rule=VertexDrelConverterRuleICEBERG.iceberg(in:ICEBERG.iceberg,out:LOGICAL)
>         at org.apache.calcite.plan.AbstractRelOptPlanner.mapRuleDescription(AbstractRelOptPlanner.java:152)
>         at org.apache.calcite.plan.volcano.VolcanoPlanner.addRule(VolcanoPlanner.java:459)
>         at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:315)
>         at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
>         at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
>         at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
>         at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
>         at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
>         at org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
>         at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
>         at org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
>         at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
>         at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
>         at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
>         ... 1 common frames omitted
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)