[Impala-ASF-CR] IMPALA-8369: Fix HMS integration tests for Hive 3

["Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>]

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13475 )

Change subject: IMPALA-8369: Fix HMS integration tests for Hive 3
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13475/4/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:

http://gerrit.cloudera.org:8080/#/c/13475/4/tests/metadata/test_hms_integration.py@205
PS4, Line 205: parse_hive3_describe_formatted_output
> The new format of the the command in hive looks very weird. I wonder if its
It seems also an intentional change and a bug as well. I looked at the test files of the 'describe formatted' command:
https://github.com/apache/hive/blob/10b6d70da1442cccf533bc97f56a622ec9f39661/ql/src/test/results/clientpositive/describe_table.q.out#L201-L216

So it seems to me that Hive switched to this vertical output format. On the other hand, the output Hive really produces has lots of garbage. Interestingly, on Hive cwiki there is an example to this strange output at https://cwiki.apache.org/confluence/display/Hive/StatsDev#StatsDev-ExistingTables , search for "the output would look like this". But I still think that it's a bug, so I opened HIVE-21824.

Anyhow, this function should parse both the intended vertical format and the buggy output as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/13475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51c91c7fc706175295b78abaacf47a86156714ce
Gerrit-Change-Number: 13475
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 12:38:08 +0000
Gerrit-HasComments: Yes