[jira] Commented: (SHINDIG-247) Refactor AbstractContentCache

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595101#action_12595101 ] 

Kevin Brown commented on SHINDIG-247:
-------------------------------------

I'm actually working in this area right now, and, incidentally, I've already implemented the exact same methods in pretty much the same way as you've proposed. 

Nobody apply this patch though, because doing so will just create some merge conflicts as I take the necessary steps to get the http stuff into common where it belongs.

> Refactor AbstractContentCache
> -----------------------------
>
>                 Key: SHINDIG-247
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-247
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Henning Schmiedehausen
>         Attachments: contentcache.patch
>
>
> The attached patch refactors the code from the AbstractContentCache class a bit:
> - add javadocs to AbstractContentCache and ContentCache
> - turn checkContent() into RemoteContent methods:
>       - isExpired() whether this RemoteContent object is expired
>       - isCacheable() whether this RemoteContent object can be cached
>       - updateExpires() modify the headers of the RemoteContent object to contain a valid expires header
> - This removes lots of functionality that is not really part of the ContentCache from AbstractContentCache and
>    turns canCache(RemoteContentRequest rcr) and canCache(RemoteContent rc) into very readable code

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.