You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/03/27 06:33:08 UTC
Review Request 19712: Replaced the element-swapping loop with
RepeatedPtrField::DeleteSubrange() to remove a slave from the registry.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19712/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
RepeatedPtrField::DeleteSubrange() has the same complexity but is cleaner.
Diffs
-----
src/master/master.hpp b6b9983464aea8ed45f62901d50da8ce118628cc
Diff: https://reviews.apache.org/r/19712/diff/
Testing
-------
mesos-tests.sh --gtest_filter=Strict/RegistrarTest* --gtest_repeat=100
Thanks,
Jiang Yan Xu
Re: Review Request 19712: Replaced the element-swapping loop with
RepeatedPtrField::DeleteSubrange() to remove a slave from the registry.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19712/#review38699
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19712]
All tests passed.
- Mesos ReviewBot
On March 27, 2014, 5:33 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19712/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:33 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> RepeatedPtrField::DeleteSubrange() has the same complexity but is cleaner.
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983464aea8ed45f62901d50da8ce118628cc
>
> Diff: https://reviews.apache.org/r/19712/diff/
>
>
> Testing
> -------
>
> mesos-tests.sh --gtest_filter=Strict/RegistrarTest* --gtest_repeat=100
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 19712: Replaced the element-swapping loop with
RepeatedPtrField::DeleteSubrange() to remove a slave from the registry.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19712/#review38819
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 27, 2014, 5:33 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19712/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:33 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> RepeatedPtrField::DeleteSubrange() has the same complexity but is cleaner.
>
>
> Diffs
> -----
>
> src/master/master.hpp b6b9983464aea8ed45f62901d50da8ce118628cc
>
> Diff: https://reviews.apache.org/r/19712/diff/
>
>
> Testing
> -------
>
> mesos-tests.sh --gtest_filter=Strict/RegistrarTest* --gtest_repeat=100
>
>
> Thanks,
>
> Jiang Yan Xu
>
>