[GitHub] [incubator-uniffle] zuston commented on pull request #534: [ISSUE-553] Avoid remove buffer multiple times when clear resource

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on PR #534:
URL: https://github.com/apache/incubator-uniffle/pull/534#issuecomment-1411721924

   LGTM.
   
   > Seems there are multiple instances for this double release.
   > Is it possible to add a ut to simulate the long app clean situation and make sure we don't encounter this problem later.
   > if is too much trouble, we than defer that in later improvement.
   
   +1. I will merge this if it still has too much work to do when adding tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org